Skip to content

better debug messages to the math-parser print #66

Description

@evykassirer

when the node isn't recognized, it'd be nice to print some tip to what the node looks like

Activity

  1. ericluap commented on Aug 7, 2017

    @ericluap
    Contributor

    Do you mean when it just prints out 'extra input not recognized'?

  2. evykassirer commented on Aug 7, 2017

    @evykassirer
    ContributorAuthor

    I think I saw "node not recognized" but that place seems good to add detail to as well! :)

  3. ericluap commented on Aug 8, 2017

    @ericluap
    Contributor

    With those, the node that wasn't recognized is also printed. I think the only place it isn't printed out is with the extra input error.

  4. evykassirer commented on Aug 8, 2017

    @evykassirer
    ContributorAuthor

    I believe it was this line

    throw new Error('unrecognized node')

  5. evykassirer commented on Aug 8, 2017

    @evykassirer
    ContributorAuthor

    the node is logged but not part of the error, so I couldn't see it

  6. ericluap commented on Aug 8, 2017

    @ericluap
    Contributor

    Ah ok, missed that one entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions