Repository navigation
make tag checks the settings version first - #15
Open
diegoparrilla wants to merge 1 commit into
Open
diegoparrilla wants to merge 1 commit into
diegoparrilla wants to merge 1 commit into
Conversation
make tag now runs make check-release first, which stops with an error unless ACONFIG_VERSION_NUMBER in rp/src/include/aconfig.h equals RELEASE_ACONFIG_VERSION in the Makefile (1; ACONFIG_H= points it at another header). Settings stored with another version are ignored and the defaults load, so an app that raises the version to start its settings again raises both, and a value used only while developing never reaches a tag. CLAUDE.md describes the check, and says where the release UUID lives: the APP_UUID secret of the GitHub repository, which CI builds with on pull requests and on the tag, falling back to the development UUID; local builds use the development UUID. version.txt v1.1.1, with its CHANGELOG.md entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
make tagfirst runs a newmake check-releasetarget. It stops with an error unlessACONFIG_VERSION_NUMBERinrp/src/include/aconfig.hequalsRELEASE_ACONFIG_VERSIONin theMakefile, which is 1 by default.ACONFIG_H=points the check at another header.CLAUDE.mddescribes the check. It also says where the release UUID lives: theAPP_UUIDsecret of the GitHub repository. CI builds with it on pull requests (build.yml) and on the tag (release.yml), and falls back to the development UUID when the secret is not available. Local builds use the development UUID.aconfig.hgets a comment onACONFIG_VERSION_NUMBER.version.txtis v1.1.1, with aCHANGELOG.mdentry.Why
Settings stored under another
ACONFIG_VERSION_NUMBERare ignored and the defaults load. An app may raise the number while developing, so that stale settings stored under the shared development UUID don't get in its way. The check makes sure that value can't reach a tag by mistake. An app that raises the version on purpose for a release, to start its settings again, raisesRELEASE_ACONFIG_VERSIONalong with it.Checked
make check-releasepasses on this tree (0x0001). It stops with an error for a header set to0x0002, passes for0x0002withRELEASE_ACONFIG_VERSION=2, and stops for a missing header.make tagitself was not run.