Repository navigation
utf8 columns: unescape strings straight into the column - #2
Merged
Merged
Conversation
get_string() unescaped each string into the parser's string buffer, then we copied it into the column. We now unescape it in place: the result is no longer than the token, and we reserve SIMDJSON_PADDING more bytes for the unescaper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_string()unescaped each string into the parser's string buffer, then we copied it into the column. We now unescape it in place withparser::unescape(): the result is no longer than the token, and we reserveSIMDJSON_PADDINGmore bytes for the unescaper. The idea comes from simdjson/simdjson#3050. Error messages are unchanged.bench_ndjson, one thread, best of 3 interleaved rounds, simdjson 5.1.1, GB/s:ghschema, validationghschema, no validationTests pass (Apple clang, GCC 16, clang 21), as do the fastpysimdjson tests with this file vendored; ASan and UBSan are clean.