Keep the Alibaba metadata address blocked for private webhook targets - #1023
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain, and the changes include regression tests and documentation updates.
Review effort: Lite
Findings: None
What changed in this PR
Updates webhook SSRF protection so Alibaba Cloud’s metadata IP remains blocked when private webhook targets are enabled.
Changes:
- Reserves
100.100.100.200/32. - Adds IPv4 and IPv6-mapped regression tests.
- Clarifies private-target and reserved-address documentation.
| File | Description |
|---|---|
src/utils/ssrfGuard.ts |
Adds the metadata address to reserved ranges. |
src/utils/__tests__/webhookPrivateTargets.test.ts |
Tests delivery blocking with private targets enabled. |
src/utils/__tests__/ssrfGuard.test.ts |
Tests address classification and URL rejection. |
docs/docs/Usage/webhooks.md |
Clarifies default webhook accessibility. |
docs/docs/Installation/options.md |
Documents reserved metadata exceptions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100.100.100.200is now reserved on its own, soWEBHOOK_ALLOW_PRIVATE_TARGETS=trueno longer opens it along with the rest of the CGNAT range. Docs reworded so the default and the opt in do not contradict each other.