Repository navigation
feat: show favicon in the header - #6
Merged
Merged
Conversation
Render favicon.svg as a 22x22 decorative image right before the yt-playlist-sync title; the h1 becomes a flex row so the icon and text stay vertically centered. The tab icon links in <head> are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renders the existing
favicon.svgas a22x22decorative image directly before theyt-playlist-synctitle in the header. Theh1becomes a flex row withalign-items:centerand an8pxgap so icon and text stay vertically centered (icon slightly taller than the 18px title text).alt=""since the label sits right next to it.The
<link rel="icon">entries in<head>for the browser tab are untouched; the file is served via the existing static mount at/favicon.svg.Checks
ruff check .cleanpytest -q178 passed (incl.test_health_and_status,test_ui_is_english)node --check app/static/app.jsok