Repository navigation
test(core): add GPU tests for the attention kernels - #51
Merged
Merged
Conversation
chmjkb
marked this pull request as draft
October 19, 2026 13:38
chmjkb
force-pushed
the
@chmjkb/gpu-suites-reduce
branch
from
October 21, 2026 15:35
8adb05a to
2cb6b71
Compare
xxpopielxx
reviewed
Oct 22, 2026
chmjkb
marked this pull request as ready for review
October 22, 2026 13:50
chmjkb
force-pushed
the
@chmjkb/gpu-suites-attention
branch
from
October 22, 2026 13:55
56dcd14 to
2401469
Compare
xxpopielxx
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GPU suites for attn, attnDecode, attnFlash and rope, with a shared f64 reference in
checkSdpa.ts(windows, GQA, sinks, segments, packed qkv).Known bugs found
d.u32(a / b), which TypeGPU compiles to an f32 division.Introduces a breaking change?
Type of change
Testing instructions
pnpm --filter runntime exec playwright install chromium(once per machine)pnpm --filter runntime test:gpu: 787 passed, 15 expected fail at this point in the stackScreenshots
Related issues
Stack: 1. reduce → 2. attention → 3. shape + elementwise → 4. matmul → 5. conv + ssm. Related: #49 (empty tensor fix), #44 (same f32 index bug in tiled matmul).
Checklist
Additional notes
src/changes. Each case says in a comment which route it takes and why; nothing asserts the route yet.it.fails. fix(core): reject an empty tensor with INVALID_ARGUMENT #49 fixes that bug; once it merges these flip toitin a follow-up commit at the bottom of the stack.it.failswith a comment naming the bug. None are fixed here.