Skip to content

Serialize panic log tests to prevent CI races - #631

Closed
coderabbitai[bot] wants to merge 11 commits into
mainfrom
coderabbit/fix-compile-listener-panic-test/0262b313
Closed

coderabbitai[bot] wants to merge 11 commits into
mainfrom
coderabbit/fix-compile-listener-panic-test/0262b313

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Add a test-only shared mutex and hold it across panic log and compile-listener panic tests in the core, native, and N-API interfaces. This prevents parallel tests from clearing or modifying the shared panic log store during another test, addressing CI failures in PR #619.

Validation was not run.

View coding task

claycuy and others added 11 commits September 16, 2026 19:23
…es (#620)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…rfaces (#621)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…622)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…624)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…e results (#628)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
lightvm Ready Ready Preview Sep 17, 2026 11:36am UTC

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Essentials

Run ID: 8b69a0fe-d6c0-4461-893d-69a1db362662

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the enhancement New feature or request label Sep 17, 2026
Base automatically changed from feat/panic-log to main September 17, 2026 12:03
@claycuy claycuy closed this Sep 22, 2026
@claycuy
claycuy deleted the coderabbit/fix-compile-listener-panic-test/0262b313 branch September 22, 2026 12:07

This branch was successfully deployed

1 active deployment
Preview faf07888 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant