Repository navigation
Prepare the 7.3.1 release - #187
Merged
Merged
Conversation
The version/documentation preparation PR that Release-Guide's prerequisites require before a tag is pushed. release-preflight.sh refuses a release whose version is not referenced by README.md, both Container-Images.md, both Migration-Guide.md, and example/quickstart/compose.yaml, so those move first. 7.3.1 rather than 7.4.0: the four PRs since 7.3.0 are two rate-limit fixes and two dependency bumps. No hook syntax, flag, response or container contract changes. README-zhCN.md was still pinning 7.2.0 everywhere while README.md was on 7.3.0 -- it is not in the preflight's file list, so it drifted a whole release without anything noticing. It is now on 7.3.1 with the English one. Its `extend-<version>` sentence is the exception: the English reads "since 7.2.0", naming when the alias was introduced, while the Chinese read "7.2.0 继续提供", naming the release that was current when it was written -- which is why that line moved with every release. It now says 自 7.2.0 起 and will not need bumping again. Both release guides get a real 7.3.1 scope section instead of 7.3.0's, and the prerequisite line names the PRs actually in this release (#182, #183, #185, #186) rather than 7.3.0's #177 and #178. Left alone on purpose: "WebHook 7.2.0 or later" in both OwlMail-Integration.md is a minimum-version requirement, not a current pin; web_test.go's 7.2.0 is an arbitrary injected build version; and build.yml's error message uses a version only as an example of the shape it wants. Verified: go build ./... clean, all release-metadata and GoReleaser tests pass, example/owlmail passes, and the preflight's six version references all resolve to 7.3.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HarHYzcGnvPbsnzD1esjpe
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version/documentation preparation PR that
docs/en-US/Release-Guide.mdlists as a prerequisite before a tag is pushed.scripts/release-preflight.shrefuses a release whose version is not referenced byREADME.md, bothContainer-Images.md, bothMigration-Guide.mdandexample/quickstart/compose.yaml, so those have to move first.What is being released
Four PRs since
7.3.0(compare):fix(ratelimit): guard the hook path against a non-positive Redis limit. redis-kit v1.6.0 changed what a non-positive limit means toCheckLimit: it used to fall into the Lua script's "no counter yet" branch and let the first request of every window through; now it means "allow nothing".HookMiddleware(0, ...)therefore went from effectively unlimited to429on every request. The global and per-IP paths already substituted a default; the hook path now has the same guard, and the repeated100 * 60literal became a named constant.fix(ratelimit): scale the Redis fallback by the configured window.checkRedisLimitcharges its limit againstconfig.WindowSeconds, so a fixed fallback count is not a fixed rate — 6000 meant 6000/hour on a 3600s window and 6000/second on a 1s one. The fallback is now computed from the normalized window. This also normalizes a negativeWindowSeconds, which the oldif window == 0check let through:CheckLimitrejects a non-positive window with an error, and the error path allows the request, so that configuration silently disabled Redis rate limiting altogether.chore(deps): upgrade all soulteary kits to their latest major versions. Ten kits; mostly import-path changes, with four relocating APIs into subpackages so the root package stops linking optional dependencies.build(deps): bump golang.org/x/time from 0.15.0 to 0.16.0.Why 7.3.1 and not 7.4.0
Two rate-limit fixes and two dependency bumps. No hook syntax, flag, response, or container contract changes — nothing that would make an existing deployment behave differently except where it was already misconfigured.
The diff
Version pins bumped to 7.3.1 across
README.md, bothContainer-Images.md, bothMigration-Guide.md,example/{quickstart,owlmail,lark,multi-webhook}andexample/owlmail/example_test.go(which asserts the compose file's pinned tag).README-zhCN.mdwas a release behind. It still pinned7.2.0everywhere whileREADME.mdwas on7.3.0— it is not in the preflight's file list, so it drifted a whole release without anything catching it. It is now on 7.3.1 alongside the English one.One line there is deliberately not a version pin. The English reads "…compatibility alias for
extended-<version>since 7.2.0" — naming when the alias was introduced. The Chinese read "7.2.0 继续提供历史名称…" — naming whichever release was current when it was written, which is why that line moved every release. It now reads 自 7.2.0 起 and matches the English, so it should not need bumping again.Both release guides get a real 7.3.1 scope section in place of 7.3.0's, and the prerequisite line names the PRs actually in this release (#182, #183, #185, #186) instead of 7.3.0's #177 and #178.
Left alone on purpose: "WebHook 7.2.0 or later" in both
OwlMail-Integration.mdis a minimum-version requirement rather than a current pin;internal/server/web_test.go's7.2.0is an arbitrary injected build version; andbuild.yml's error message uses a version only as an example of the shape it wants.Verification
go build ./...— clean.go test -run 'TestGoReleaser|TestRelease' .— all 12 release-metadata and GoReleaser tests pass.go test ./example/owlmail/...— passes, including the compose-tag assertion.7.3.1.README.mdandREADME-zhCN.mdcarry mixed CRLF/LF (160 and 165 CRLF lines) and keep exactly that, so the diff is only the version strings.Note:
TestSetupLogger_ErrorHandlingandTestSetupLogger_ErrorInLogQueuefail in my sandbox, but they fail identically on a cleanorigin/maincheckout — they assert that writing into a0444directory fails, which it does not when the test runs as uid 0. Unrelated to this change, and they pass on CI's non-root runner.After merging
Generated by Claude Code