Repository navigation
feat(rpc): committed_fallback option for buildchainproof - #214
Merged
Merged
Conversation
build_chain_proof errored when a requested record was updated after the last commit (most_recent_update > last_committed), because it resolved keys from live state but proves against the committed snapshot — so cert relays could not resolve a space right after e.g. an auction commitment moved its outpoint, until the next commit (~up to 36 blocks). Add an optional committed_fallback flag (default false, old behavior preserved for consumers that rely on the not-yet-committed error). When true, keys are resolved against the last committed snapshot so a moved record resolves to its committed state and never errors; a not-yet-committed record proves as non-existent (correct — not anchored yet). Reuses existing lookups: a committed snapshot is an empty-staged SpLiveSnapshot/NumLiveSnapshot (new SpStore/NumStore::read_committed), so get_space_info/get_num_info run unchanged against it; numeric->id resolution stays on the SQLite index (commit-independent). No API/result shape change.
buffrr
force-pushed
the
committed-chain-proof
branch
from
September 21, 2026 12:52
deb4e9f to
1fb5c0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_chain_proof errored when a requested record was updated after the last commit (most_recent_update > last_committed), because it resolved keys from live state but proves against the committed snapshot — so cert relays could not resolve a space right after e.g. an auction commitment moved its outpoint, until the next commit (~up to 36 blocks).
Add an optional committed_fallback flag (default false, old behavior preserved for consumers that rely on the not-yet-committed error). When true, keys are resolved against the last committed snapshot so a moved record resolves to its committed state and never errors; a not-yet-committed record proves as non-existent (correct — not anchored yet).
Reuses existing lookups: a committed snapshot is an empty-staged SpLiveSnapshot/NumLiveSnapshot (new SpStore/NumStore::read_committed), so get_space_info/get_num_info run unchanged against it; numeric->id resolution stays on the SQLite index (commit-independent). No API/result shape change.