docs: delete the two ADRs the machine artefact made obsolete - #4
Merged
Conversation
ADR-0022 pinned and mirrored spinbox's kernel through a registry, because that kernel was another repository's build output with no published home. ADR-0025 took QEMU out of the image that built it, because that QEMU was dynamically linked against it. Both premises are gone: QEMU, the guest kernel and the firmware are one versioned spin-machine release, statically linked, pinned by version and SHA-256, and `Dockerfile.qemu`, `Dockerfile.guest-kernel` and `qemu.yml` no longer exist. They are deleted rather than amended. An ADR whose decision no longer binds anything is not history worth carrying in the tree; git has it. ADR-0021 keeps §1-§4 — the dependency direction and the harness rule are still what the Go code cites. Only §5 goes: it said storage consumes spinbox's kernel artefact, and it does not. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019GHRRFvbnZi5q3KSTvyW5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0022 and ADR-0025 both decided how to work around something that no longer exists.
_output/on whoever rantask build:kernellast, so there was nothing to point a URL at andDockerfile.guest-kernelmoved it through a registry. There is a published machine release now, pinned by version and SHA-256, and nothing to mirror.runtimestage ofDockerfile.qemu(liburing.so.2: cannot open shared object file). QEMU is static;qemu:tools,Dockerfile.qemuandqemu.ymlare gone.Deleted rather than amended — an ADR that no longer binds anything is not history worth carrying in the tree, and git has it.
ADR-0021 stays, minus §5. §1 (spin imports storage, never the reverse) and §2 (the binaries are test harnesses) are cited from ~10 places in the Go tree and are still the operative decision. §5 said storage consumes spinbox's kernel artefact; it consumes a spin-machine release instead, which is the same principle with a different source, and is already stated where
task machinelives.Also dropped the trailing references to the deleted files in
ci.yml,CLAUDE.md,hack/spin-machine,hack/demo-lib.shandtaskfiles/machine.yml, and refreshed the staleqemu:tools/guest:kernel:fetchlines in the CLAUDE.md task list.🤖 Generated with Claude Code
https://claude.ai/code/session_019GHRRFvbnZi5q3KSTvyW5a