Update stellar-strkey to 0.0.18 by leighmcculloch · Pull Request #2614 · stellar/stellar-cli

leighmcculloch · 2026-06-17T02:54:28Z

Note

Updating the lib across the stack:

What

Bump the workspace stellar-strkey dependency to =0.0.18.

Why

This adopts the latest stellar-strkey release.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XiSfu2MM5xbdGjxj7oXys8

0.0.18 includes the strkey CLI fix (accept owned variant keys for Decoded<Strkey>). It is not yet on crates.io, so temporarily patch stellar-strkey to the release/v0.0.18 branch to validate ahead of the release. Remove the patch once 0.0.18 is published.

0.0.18 is now published to crates.io, so drop the temporary [patch.crates-io] that pointed stellar-strkey at the release/v0.0.18 git branch (and the matching stellar-cli deny.toml allow-git entry). The dependency now resolves from crates.io.

Copilot

✅ Ready to approve

The dependency bump is consistently applied, required call sites/tests are updated for the new redaction/stdin behaviors, and no correctness issues were identified in the changed regions.

Note: this review does not count toward required approvals for merging.

Pull request overview

Bumps the workspace stellar-strkey dependency to 0.0.18 (Protocol 28 line) and updates the CLI/spec tooling glue code and tests to match upstream API/CLI behavior changes (more specific decode errors, secret redaction via Unredacted, and strkey encode/decode reading from stdin).

Changes:

Update workspace dependency to stellar-strkey = 0.0.18 (and refresh Cargo.lock for new transitive graph).
Adjust hex-fallback contract ID parsing to map failures to DecodeError::InvalidPayloadLength.
Update secret-key printing/serialization and tests to use .as_unredacted(), and update strkey integration tests to pass input via stdin.

File summaries

File	Description
cmd/soroban-cli/src/utils.rs	Updates contract ID hex-fallback error mapping for new `stellar-strkey` decode error variants.
cmd/soroban-cli/src/config/secret.rs	Ensures secret-key serialization and assertions use unredacted formatting.
cmd/soroban-cli/src/config/key.rs	Updates key round-trip test to serialize secret keys using `.as_unredacted()`.
cmd/soroban-cli/src/commands/network/root_account/secret.rs	Prints root account secret key using `.as_unredacted()` to avoid redaction.
cmd/soroban-cli/src/commands/keys/secret.rs	Prints identity secret key using `.as_unredacted()` to avoid redaction.
cmd/crates/soroban-test/tests/it/strkey.rs	Updates `strkey encode/decode` integration tests to provide input via stdin (no positional input).
cmd/crates/soroban-test/src/lib.rs	Updates test helper output to use `.as_unredacted()` for secret key display.
cmd/crates/soroban-spec-tools/src/utils.rs	Mirrors CLI contract ID parsing error mapping changes in shared spec tools.
Cargo.toml	Bumps workspace `stellar-strkey` dependency to 0.0.18.
Cargo.lock	Records new `stellar-strkey` 0.0.18 node and transitive dependency updates (incl. additional heapless version).

Copilot's findings

Files reviewed: 9/10 changed files
Comments generated: 0

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d20a12a9af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

stellar-strkey 0.0.18's embedded encode/decode commands read their input from stdin instead of a positional argument, so the generated FULL_HELP_DOCS.md entries for `stellar strkey decode/encode` were stale. Regenerated the strkey section to match (stdin input, new --quiet option).

Copilot

Copilot review overview

🟢 Approval recommended

The only noted issue is a non-blocking dependency-version pinning nit.

Review effort: Lite
Findings: 1

Open (1)

Pin dependency to exact version 0.0.18 · New

Copilot

Copilot review overview

🔵 Needs a closer look

Pin the workspace dependency explicitly to =0.0.18 in Cargo.toml.

Review effort: Lite
Findings: None

Resolved since last review (1)

Pin dependency to exact version 0.0.18

> [!NOTE] > Updating the lib across the stack: > - stellar/rs-stellar-xdr#547 > - stellar#1694 > - stellar/rs-soroban-sdk#1913 > - stellar/rs-stellar-rpc-client#99 > - stellar/stellar-cli#2614 ### What Bump the workspace `stellar-strkey` dependency to `=0.0.18`. ### Why This adopts the latest `stellar-strkey` release. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

> [!NOTE] > Updating the lib across the stack: > - stellar/rs-stellar-xdr#547 > - stellar/rs-soroban-env#1694 > - stellar#1913 > - stellar/rs-stellar-rpc-client#99 > - stellar/stellar-cli#2614 ### What Bump the workspace `stellar-strkey` dependency to `=0.0.18`. ### Why This adopts the latest `stellar-strkey` release. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

This reverts commit c4cc455.

### What Wrap the embedded strkey CLI so that `stellar strkey decode` and `stellar strkey encode` accept their input as an argument again, falling back to stdin when it is omitted. ### Why Updating stellar-strkey to 0.0.18 in #2614 made the embedded CLI read that input only from stdin, which breaks existing scripts that run `stellar strkey decode <STRKEY>` or `stellar strkey encode <JSON>`. ### Known limitations The argument path copies the embedded CLI's decode and encode logic, with a test checking that both paths stay in sync, until the wrapper is deleted at the next major version (v29/30).

update stellar-strkey to 0.0.17

ea0f408

github-project-automation Bot added this to DevX Jun 17, 2026

github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jun 17, 2026

leighmcculloch and others added 4 commits June 17, 2026 05:32

adapt cli to strkey 0.0.17 private key api

ce09d34

format private key rendering changes

697f4e9

update strkey cli tests for 0.0.17 stdin interface

218fdf0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XiSfu2MM5xbdGjxj7oXys8

update stellar-strkey to 0.0.18

7872921

0.0.18 includes the strkey CLI fix (accept owned variant keys for Decoded<Strkey>). It is not yet on crates.io, so temporarily patch stellar-strkey to the release/v0.0.18 branch to validate ahead of the release. Remove the patch once 0.0.18 is published.

leighmcculloch changed the title ~~Update stellar-strkey to 0.0.17~~ Update stellar-strkey to 0.0.18 Jun 17, 2026

leighmcculloch added 2 commits June 18, 2026 03:22

depend on published stellar-strkey 0.0.18

8575cc6

0.0.18 is now published to crates.io, so drop the temporary [patch.crates-io] that pointed stellar-strkey at the release/v0.0.18 git branch (and the matching stellar-cli deny.toml allow-git entry). The dependency now resolves from crates.io.

Merge branch 'main' into update-stellar-strkey-0-0-17

d20a12a

leighmcculloch marked this pull request as ready for review June 18, 2026 04:06

Copilot AI lite review requested due to automatic review settings June 18, 2026 04:06

Copilot started reviewing on behalf of leighmcculloch June 18, 2026 04:07 View session

Copilot AI approved these changes Jun 18, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread Cargo.toml

leighmcculloch requested a review from a team September 23, 2026 21:32

leighmcculloch mentioned this pull request Sep 24, 2026

Update stellar-strkey to 0.0.18 and add min length to BytesM for signed payloads stellar/rs-stellar-xdr#591

Closed

leighmcculloch added 2 commits September 24, 2026 10:20

merge main into update-stellar-strkey-0-0-17

5dbd5e1

return strkey error when contract id hex fails

ec41fc7

Copilot AI review requested due to automatic review settings September 24, 2026 10:20

Copilot started reviewing on behalf of leighmcculloch September 24, 2026 10:21 View session

Copilot AI reviewed Sep 24, 2026

View reviewed changes

Comment thread Cargo.toml

merge main into update-stellar-strkey-0-0-17

20c809a

Copilot AI review requested due to automatic review settings September 24, 2026 20:43

Copilot started reviewing on behalf of leighmcculloch September 24, 2026 20:44 View session

Copilot AI reviewed Sep 24, 2026

View reviewed changes

sisuresh approved these changes Sep 24, 2026

View reviewed changes

leighmcculloch merged commit c4cc455 into main Sep 24, 2026
204 of 244 checks passed

leighmcculloch deleted the update-stellar-strkey-0-0-17 branch September 24, 2026 21:09

github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Sep 24, 2026

fnando added a commit that referenced this pull request Sep 25, 2026

Revert "Update stellar-strkey to 0.0.18 (#2614)"

5f6d84f

This reverts commit c4cc455.

leighmcculloch mentioned this pull request Sep 26, 2026

Accept strkey decode/encode input as an argument #2757

Merged

Navigation Menu

Update stellar-strkey to 0.0.18 - #2614

Update stellar-strkey to 0.0.18#2614
leighmcculloch merged 11 commits into
mainfrom
update-stellar-strkey-0-0-17

leighmcculloch commented Jun 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leighmcculloch commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

✅ Ready to approve

Copilot's findings

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leighmcculloch commented Jun 17, 2026 •

edited

Loading