Reduce qualified type and event names

[leighmcculloch]

Note

Part of a stack of PRs listed here:

• Fixing a few issues with the soroban-sdk's production of specs (type ids, name collisions, aliasing, ...) stellar-protocol#2014

What

Reduce the fully qualified UDT type names that stellar/rs-soroban-sdk#1970 emits (e.g. my_contract::inner::State) down to short names during the build process.

Why

The soroban-sdk will be emitting fully qualified user-defined type names as an intermediary step so that the stellar-cli can reduce the spec to only those types needed by the exported interface of a contract, and so that types will be guaranteed to have unique names. The long names are not good for most tooling though which is already accustomed to the short simple names. The cli can make this change in the soroban-sdk a no-op for the rest of the ecosystem by converting the names to unique simple names during the build step.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues affect correctness, safety, coverage, and consistency across build paths.

Review effort: Lite
Findings: 1 · 3 · 1

Open (5)

• Use the pinned non-fallible soroban-spec reduction API
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved moderate issues affect build behavior, output correctness, warning safety, and regression coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

Resolved since last review (1)

• Use the pinned non-fallible soroban-spec reduction API

[Copilot]

Copilot review overview

🟡 Changes recommended

Multiple moderate issues remain unresolved, including a compilation blocker and incomplete build-path handling.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation · New
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved correctness, security, and test-coverage issues remain.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved correctness, safety, container-path, and integration-testing issues remain.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues remain around sanitization, integration coverage, image builds, and event-name diagnostics.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

The unresolved moderate issues can omit rewrites, affect container builds, reduce regression coverage, and expose unsafe terminal output.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues remain in reference rewriting, container builds, warning sanitization, diagnostics, and end-to-end coverage.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved moderate findings include a compile-blocking API mismatch, bypassed reduction paths, incomplete coverage, and diagnostic-output issues.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues affect sanitization, coverage, reference rewriting, container builds, and warning accuracy.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved moderate issues affect security, build-path consistency, test coverage, and diagnostic accuracy.

Review effort: Lite
Findings: 5 · 1

Open (6)

• Prevent terminal injection through unsanitized reduction errors · New
• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Moderate issues remain in build coverage, artifact handling, reference reduction, warning accuracy, and diagnostic sanitization.

Review effort: Lite
Findings: 5 · 1

Open (6)

• Prevent terminal injection through unsanitized reduction errors
• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues affect reference rewriting, container builds, output sanitization, and test coverage.

Review effort: Lite
Findings: 5 · 1

Open (6)

• Prevent terminal injection through unsanitized reduction errors
• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Spec-derived warning text needs sanitization, accurate wording, and command-level integration coverage.

Review effort: Balanced
Findings: 5 · 1

Open (6)

• Prevent terminal injection through unsanitized reduction errors
• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

The no-op check can discard reference-only reductions.

Review effort: Balanced
Findings: 3

Open (3)

• Add coverage for nested references, events, and collision disambiguation
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction

Resolved since last review (3)

• Prevent terminal injection through unsanitized reduction errors
• Sanitize rename values before including them in warnings
• Collision warning should include event names