Add contract bindings subcommand for kmp - #2721
Merged
Merged
Conversation
The kmp subcommand mirrors the python, java, flutter, swift, and php stubs: binding generation is not implemented in the CLI and the error points at the external stellar-contract-bindings tool. FULL_HELP_DOCS.md carries the regenerated entries.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the stellar contract bindings kmp command, directing users to the external Kotlin Multiplatform bindings generator.
Changes:
- Registers and dispatches the new KMP subcommand.
- Adds its external-tool error message.
- Updates generated CLI documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
FULL_HELP_DOCS.md |
Documents KMP bindings usage. |
cmd/soroban-cli/src/commands/contract/bindings/kmp.rs |
Implements the external-tool notice. |
cmd/soroban-cli/src/commands/contract/bindings.rs |
Registers and dispatches the command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
cmd/soroban-cli/src/commands/contract/bindings.rs:34
- This adds a new CLI route without the required
soroban-testcoverage. Please add an integration test that invokesstellar contract bindings kmpthrough the command entry point and asserts it reaches the KMP handler and returns the documentedstellar-contract-bindingsURL; otherwise a missing module registration, dispatch arm, or changed error message could go unnoticed.
/// Generate Kotlin Multiplatform bindings
Kmp(kmp::Cmd),
Note
Copilot is running an experiment and ran this review at Lite.
fnando
approved these changes
Sep 15, 2026
Contributor
Author
|
thank you |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
stellar contract bindings kmpsubcommand. Like thepython,java,flutter,swiftandphpsubcommands, it displays a link to thestellar-contract-bindingstool.Why
stellar-contract-bindings0.6.0b0 generates Kotlin Multiplatform bindings for the KMP Stellar SDK.Known limitations
The bindings are not generated by the cli. The cli only displays the link to the
stellar-contract-bindingstool, like the other subcommands above.