Skip to content

fix(browser): make get_html truncation configurable instead of hard-coded 1000 chars #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangwangbobo wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix(browser): make get_html truncation configurable instead of hard-coded 1000 chars #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/strands_tools/browser/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,9 +594,10 @@ async def _async_get_html(self, action: GetHtmlAction) -> Dict[str, Any]:
],
}

# Truncate long HTML content
truncated_result = result[:1000] + "..." if len(result) > 1000 else result
return {"status": "success", "content": [{"text": truncated_result}]}
# Optionally truncate HTML content
if action.max_length is not None and len(result) > action.max_length:
result = result[:action.max_length] + "..."
return {"status": "success", "content": [{"text": result}]}
except Exception as e:
logger.debug("exception=<%s> | get HTML action failed", str(e))
return {"status": "error", "content": [{"text": f"Error: {str(e)}"}]}
Expand Down
1 change: 1 addition & 0 deletions src/strands_tools/browser/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ class GetHtmlAction(BaseModel):
type: Literal["get_html"] = Field(description="Get HTML content")
session_name: str = Field(description="Required session name from a previous init_session call")
selector: Optional[str] = Field(default=None, description="CSS selector for specific element (optional)")
max_length: Optional[int] = Field(default=None, description="Maximum characters to return. None returns full HTML.")


class ScreenshotAction(BaseModel):
Expand Down
Loading