Skip to content

ci: use quick macOS native checks on main - #1433

Draft
bvolpato wants to merge 1 commit into
substrait-io:mainfrom
bvolpato:bvolpato/native-macos-quick-build
Draft

bvolpato wants to merge 1 commit into
substrait-io:mainfrom
bvolpato:bvolpato/native-macos-quick-build

Conversation

@bvolpato

@bvolpato bvolpato commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Use --quick-build-native for the macOS native check on main pushes, matching the mode already used by Linux PR checks. Keep full optimization for the weekly macOS check, release builds, and manual runs by default. Both macOS smoke suites still run after compilation.

Across 66 successful macOS jobs in the past 30 days, the median duration was 29.8 minutes and the p95 was 40.4 minutes. Native compilation accounted for most of that time. In one quick-mode fork run, the complete job took 23 minutes 31 seconds, including both smoke suites. The log confirms GraalVM used -Ob. This is one quick run compared with historical full builds, not a controlled paired benchmark.

The tradeoff is that regressions specific to full optimization would be caught by the weekly or manual check rather than after every merge. Manual dispatch also accepts an optional quick-build flag, including on forks, so contributors can test this path before proposing changes.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant