Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
--quick-build-nativefor the macOS native check on main pushes, matching the mode already used by Linux PR checks. Keep full optimization for the weekly macOS check, release builds, and manual runs by default. Both macOS smoke suites still run after compilation.Across 66 successful macOS jobs in the past 30 days, the median duration was 29.8 minutes and the p95 was 40.4 minutes. Native compilation accounted for most of that time. In one quick-mode fork run, the complete job took 23 minutes 31 seconds, including both smoke suites. The log confirms GraalVM used
-Ob. This is one quick run compared with historical full builds, not a controlled paired benchmark.The tradeoff is that regressions specific to full optimization would be caught by the weekly or manual check rather than after every merge. Manual dispatch also accepts an optional quick-build flag, including on forks, so contributors can test this path before proposing changes.