Skip to content

🔄 Sync supportpal/addon-language-english - #6

Merged
bytestream merged 1 commit into
masterfrom
sync
Sep 10, 2026
Merged

bytestream merged 1 commit into
masterfrom
sync

Conversation

@bytestream

Copy link
Copy Markdown
Member

Synced files with /addon-language-english.


This PR was created automatically by #11385185308

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the Persian (Farsi/fa) language files with the English language repository, incorporating translations for new features introduced in versions 5.4.1 through 5.7.5. The changes primarily reorganize existing translations under appropriate version sections and add new translation keys for enhanced notification systems, ticket management features, and UI improvements.

Key Changes

  • Notification System Refactor: Removed legacy notification strings and added comprehensive new notification management translations including department subscriptions, notification channels, and granular notification preferences
  • Version Organization: Relocated numerous translation keys to their appropriate version sections (5.4.1, 5.5.0, 5.6.0, 5.7.0, 5.7.3, 5.7.5) for better maintainability
  • GitHub Actions Update: Upgraded checkout action from v4 to v5 and phplint from 9.1 to 9.5 in CI workflows

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/test.yml Updated GitHub Actions dependencies (checkout@v5, phplint@9.5)
.github/workflows/release.yml Updated GitHub Actions checkout to v5
Lang/fa/actions.php Replaced combined "close_and_lock_ticket" with separate "close_ticket" and "lock_ticket" actions
Lang/fa/core.php Added table editor UI strings, captcha labels, and relocated ticket channel description
Lang/fa/general.php Added "mark_as_done", "bot", and "allow_all" translations
Lang/fa/integrations.php Reorganized Twilio verification strings and added Microsoft tenant ID configuration
Lang/fa/license.php Added license key update success message
Lang/fa/locale.php Reordered Istanbul timezone entry (maintainability issue identified)
Lang/fa/log.php Added audit log entries for ticket pinning and operator notification updates
Lang/fa/messages.php Added throttle error message with dynamic time placeholder
Lang/fa/permission.php Added permissions for operator notifications and reply templates
Lang/fa/report.php Added "group_by" translation for reporting features
Lang/fa/selfservice.php Reorganized published_desc and added comment notification strings
Lang/fa/ticket.php Added comprehensive notification descriptions, rate limiting settings, and ticket action translations; relocated allowed_files_desc
Lang/fa/user.php Removed legacy notification strings; added extensive operator notification subscription system translations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Lang/fa/locale.php
"Europe/Vilnius" => "(GMT+02:00) Vilnius",
"Africa/Windhoek" => "(GMT+02:00) Windhoek",
"Asia/Baghdad" => "(GMT+03:00) Baghdad",
"Europe/Istanbul" => "(GMT+02:00) Istanbul",

Copilot AI Dec 3, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timezone "Europe/Istanbul" is labeled as "(GMT+02:00)" but is positioned after "Asia/Baghdad" which is labeled as "(GMT+03:00)". This breaks the logical ordering of timezones by GMT offset. The entry should either remain in its original position among other GMT+02:00 timezones, or its GMT offset should be corrected if it has changed.

Suggested change
"Europe/Istanbul" => "(GMT+02:00) Istanbul",
"Europe/Istanbul" => "(GMT+03:00) Istanbul",

Copilot uses AI. Check for mistakes.
@bytestream
bytestream force-pushed the sync branch 3 times, most recently from bb70f68 to 659c232 Compare June 23, 2026 13:22
@bytestream
bytestream merged commit 4eb7b8b into master Sep 10, 2026
2 checks passed
@bytestream
bytestream deleted the sync branch September 10, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants