Repository navigation
fix: announce a presence channel user once across all of their sockets - #89
Merged
Merged
Conversation
Two sockets of the same user joining at the same time could each find the other and neither announce the user. Announce from the user's earliest socket on the channel instead, as Laravel Reverb does, so exactly one of them does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were announcing
member_addedevery time a new tab was opened, andmember_removedevery time a tab was closed or orphaned row garbage collected. This changes that behaviour so it only does it once if there's a connection live elsewhere. It mimics pusher-js behaviour.