Repository navigation
feat: dynamic pre-roll based on silence threshold crossing - #43
Merged
Merged
Conversation
…nce threshold The fixed 100ms pre-roll was insufficient for gradual speech attacks, causing clipped playback starts. Now scans backward through buffered chunks to find where audio first rises above the silence threshold, then adds a 100ms safety margin beyond that point. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
silenceThresholdDb, then adds a 100ms safety margin beyond that pointfindPreRollStartFrame()helper function and corresponding unit testsTest plan
pnpm typecheckpasses with no errorspnpm lintpasses with no new errors🤖 Generated with Claude Code