Skip to content

Move php7-v2 to master #137

Description

@Totktonada

It seems that community prefer php7 and now we can obsolete php5 support. I propose to move current master (php5) into the separate branch and move php7-v2 branch (force-push or merge, don't sure) to master.

Packages then will be build for php7, so #117 (and #136) will be fixed.

We need to elaborate what additional work is needed here: update docker images and so on.

@bigbes Can you please comment?

Activity

  1. Totktonada commented on Mar 23, 2020

    @Totktonada
    ContributorAuthor

    Blocked on:

  2. added this to the Support PHP 7.* milestone on Mar 23, 2020
  3. Totktonada commented on Mar 28, 2020

    @Totktonada
    ContributorAuthor

    As part of this issue we should ensure that all commits into master branch since php7-v2 forking point are either unrelevant or reflected in the php7-v2 branch.

    What to inspect:

    $ git merge-base origin/master origin/php7-v2
    61b9d7bc15d78e210b58e2a16feecdb3982923a9
    $ git log 61b9d7bc15d78e210b58e2a16feecdb3982923a9..origin/master
  4. self-assigned this
    on Jun 29, 2020
  5. Totktonada commented on Jun 29, 2020

    @Totktonada
    ContributorAuthor
    • Created new php5 branch, which is even with current master (03fc9fe, 0.1.0-49-g03fc9fe).
    • Force-pushed master branch with latest php7-v2 commit (ad221f7, 0.3.2-39-gad221f7).
    • Changed target from php7-v2 to master in open PRs.

    Nothing more to do here. We should carefully look at README (whether it is actual) as follow up. See also PR #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions