Conversation
happz
added this pull request to stack #5166
September 15, 2026 21:02
happz
added
ci | full test
LecrisUT
approved these changes
Sep 16, 2026
therazix
force-pushed
the
reboot-restart-context-logging
branch
from
September 17, 2026 13:03
efab317 to
2746aff
Compare
bajertom
reviewed
Sep 17, 2026
Comment on lines
+101
to
+112
| if reboot: | ||
| self.logger.debug( | ||
| f"Restart during {self.owner_label}" | ||
| f" with reboot count {reboot.reboot_counter}" | ||
| f" and restart count {self.restart_counter}." | ||
| ) | ||
|
|
||
| else: | ||
| self.logger.debug( | ||
| f"Restart during {self.owner_label} with restart count {self.restart_counter}." | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
With this section moved above the
else:
self.restart_counter += 1
there is now discrepancy between the debug messages WRT to counters:
main:
Hard reboot during test '/tests/mujtest/restart-with-reboot-test' with reboot count 1 and test restart count 1.
Hard reboot using the testcloud API.
Triggering hard reboot with '<function GuestTestcloud.reboot.<locals>.<lambda> at 0x7f8a8dce1f30>'.
wait: waiting for condition '<lambda>' with timeout 0:10:00, deadline in 600.0 seconds, checking every 30.00 seconds <Deadline: now=345535.365870988 deadline=346135.365870988>
Execute command 'export PYTEST='python3 -m pytest -vvv -ra --showlocals'; export TMT_VERSION=1.78.0; export TMT_TREE=/var/tmp/tmt/run-075/plans/mujplan/mujplan/tree; export TMT_PLAN_DATA=/var/tmp/tmt/run-075/plans/mujplan/mujplan/data; export TMT_PLAN_SOURCE_SCRIPT=/var/tmp/tmt/run-075/plans/mujplan/mujplan/data/plan-source-script.sh; export TMT_PLAN_ENVIRONMENT_FILE=/var/tmp/tmt/run-075/plans/mujplan/mujplan/data/variables.env-default-0; cat /proc/stat' on guest '127.0.0.1'.
wait: '<lambda>' finished successfully, 583.44 seconds left <Deadline: now=345551.922380612 deadline=346135.365870988>
Connection to guest succeeded after reboot.
Test restart during test '/tests/mujtest/restart-with-reboot-test' with reboot count 1 and restart count 1.
PR:
Restart during test '/tests/mujtest/restart-with-reboot-test' with reboot count 0 and restart count 0.
Hard reboot during test '/tests/mujtest/restart-with-reboot-test' with reboot count 1 and restart count 1.
is this intended?
Restart context did log, but after many steps it already took. Therefore there were several actions in the log taken on behalf of the restart context, just without the context announcing it would apply. Reboot context speaks about "test" but it's no longer test-only.
therazix
force-pushed
the
reboot-restart-context-logging
branch
from
September 18, 2026 19:55
2746aff to
2c7b762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist