Skip to content

test: add golden generator coverage - #12

Merged
brendanjryan merged 1 commit into
mainfrom
test/golden-generators
Sep 3, 2026
Merged

test: add golden generator coverage#12
brendanjryan merged 1 commit into
mainfrom
test/golden-generators

Conversation

@brendanjryan

Copy link
Copy Markdown
Collaborator

Motivation

Generated marketplace artifacts are public interfaces. Exact-output tests make metadata changes reviewable and prevent silent cross-platform drift.

Summary

  • Add golden files for every generated manifest, extension manifest, and release plugin name
  • Make generation functions independently testable
  • Add a deterministic golden refresh command
  • Detect and remove orphaned generated manifests
  • Prevent internal launch-state language from returning to public documentation

Key design considerations

  • Keep golden updates explicit and reviewer-controlled
  • Verify copied skills and licenses byte-for-byte without duplicating them in fixtures
  • Limit pruning to known generated manifest paths

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T19:47:01.222272Z 4d48dcd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brendanjryan
brendanjryan merged commit 0ce8154 into main Sep 3, 2026
3 checks passed
@brendanjryan
brendanjryan deleted the test/golden-generators branch September 3, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant