Skip to content

Polish bulk deconvolution chapter - #516

Open
seohyonkim wants to merge 9 commits into
mainfrom
feature/bulk-decon
Open

seohyonkim wants to merge 9 commits into
mainfrom
feature/bulk-decon

Conversation

@seohyonkim

@seohyonkim seohyonkim commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator
  • Changed chapters were re-executed in their own .yml environment and the outputs are committed
  • Data is loaded from and saved to lamindb (ln.connect("theislab/sc-best-practices"), ln.track(...), ln.finish())
  • New dependencies are in the chapter .yml, and new environments are added to .github/workflows/build_environments.yml
  • New citations are in the chapter .bib with a verified doi and url
  • The _keytakeaways.txt file is updated if the key messages changed
  • Glossary terms are linked with {term}`...` on first occurrence
  • Markdown has one sentence per line

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@netlify

netlify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for sc-best-practices ready!

Name Link
🔨 Latest commit 26e94eb
🔍 Latest deploy log https://app.netlify.com/projects/sc-best-practices/deploys/6af9e90eea9cdd470f25d859
😎 Deploy Preview https://deploy-preview-516--sc-best-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@seohyonkim seohyonkim changed the title WIP Feature/bulk decon Polish bulk deconvolution chapter Nov 9, 2026
@seohyonkim
seohyonkim marked this pull request as ready for review November 9, 2026 13:05
@seohyonkim
seohyonkim requested a review from Zethson November 9, 2026 13:12

@Zethson Zethson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I'll have a look at the notebooks later and will ping you then.

- pip:
- lamindb==2.12.2
# rectanglepy pins numpy<2 and scipy==1.13.0, which has no wheels for Python 3.13
- rectanglepy==1.7.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eww this is just outdated and unmaintained stuff then. We cannot use it.

- rectanglepy==1.7.0
# pyarrow 26 requires numpy>=2
- pyarrow==25.0.0
- scanpy==1.11.5

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's old. Can we please use the latest versions of everything?

dependencies:
- conda-forge::ipykernel=7.3.0
- conda-forge::ipywidgets=8.1.9
- conda-forge::python=3.12.16

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go 3.14, please?

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that an analogy might help understand it but IDK whether we really need it


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda cute but I think if we cut the analogy we can still expain these very simple concepts and cut the word count in the chapter by like 30%


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The titles look very AI.

This is too much text. The explanation is for a 5 year old but not a scientist. I think we can expect a little more and remove the analogy.


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have chapters where we're discussing benchmarks like this. We always integrated benchmark resutls into the actual text.


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really ist tools. We only mention the ones that are best or for a specfic type of analysis.


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three datasets are stored in the lamindb instance of this book.

no need to mention this


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they not offer a plot in the rectangle package? Sad


Reply via ReviewNB

@@ -9,6 +9,7 @@
"authors:\n",

@Zethson Zethson Nov 9, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a compromise back then to get the original authors to at least finish the work. We can also remove this. These aren't new directions when the papers are from 2019-2022


Reply via ReviewNB

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants