Repository navigation
Polish bulk deconvolution chapter - #516
seohyonkim wants to merge 9 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
✅ Deploy Preview for sc-best-practices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Zethson
left a comment
There was a problem hiding this comment.
Thanks!
I'll have a look at the notebooks later and will ping you then.
| - pip: | ||
| - lamindb==2.12.2 | ||
| # rectanglepy pins numpy<2 and scipy==1.13.0, which has no wheels for Python 3.13 | ||
| - rectanglepy==1.7.0 |
There was a problem hiding this comment.
Eww this is just outdated and unmaintained stuff then. We cannot use it.
| - rectanglepy==1.7.0 | ||
| # pyarrow 26 requires numpy>=2 | ||
| - pyarrow==25.0.0 | ||
| - scanpy==1.11.5 |
There was a problem hiding this comment.
That's old. Can we please use the latest versions of everything?
| dependencies: | ||
| - conda-forge::ipykernel=7.3.0 | ||
| - conda-forge::ipywidgets=8.1.9 | ||
| - conda-forge::python=3.12.16 |
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
I understand that an analogy might help understand it but IDK whether we really need it
Reply via ReviewNB
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
Kinda cute but I think if we cut the analogy we can still expain these very simple concepts and cut the word count in the chapter by like 30%
Reply via ReviewNB
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
The titles look very AI.
This is too much text. The explanation is for a 5 year old but not a scientist. I think we can expect a little more and remove the analogy.
Reply via ReviewNB
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
We don't have chapters where we're discussing benchmarks like this. We always integrated benchmark resutls into the actual text.
Reply via ReviewNB
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
We don't really ist tools. We only mention the ones that are best or for a specfic type of analysis.
Reply via ReviewNB
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
All three datasets are stored in the lamindb instance of this book.
no need to mention this
Reply via ReviewNB
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
| @@ -9,6 +9,7 @@ | |||
| "authors:\n", | |||
There was a problem hiding this comment.
This was a compromise back then to get the original authors to at least finish the work. We can also remove this. These aren't new directions when the papers are from 2019-2022
Reply via ReviewNB
.ymlenvironment and the outputs are committedln.connect("theislab/sc-best-practices"),ln.track(...),ln.finish()).yml, and new environments are added to.github/workflows/build_environments.yml.bibwith a verifieddoiandurl_keytakeaways.txtfile is updated if the key messages changed{term}`...`on first occurrence