Repository navigation
tidybulk Replace pivot_* with subset_* #181
Description
I think subset_transcripts and subset_samples would be more clear and in line with tidyverse. @mblue9 concerns?
{{ message }}
tidybulk Replace pivot_* with subset_* #181I think subset_transcripts and subset_samples would be more clear and in line with tidyverse. @mblue9 concerns?
Activity
mblue9 commentedon May 6, 2021
Nope no concerns just wondering what you mean by it would be more in line with tidyverse?
stemangiola commentedon May 6, 2021
For example, the filter function from dplyr mention the word subset https://dplyr.tidyverse.org/reference/filter.html
Plus subset is more comprehensible by the general audience than pivot, which is a quite abstract term. This is a vocabulary choice, and there is no right answer.
What do you think and user?
mblue9 commentedon May 7, 2021
Maybe subset_ is easier to understand. Or in that case why not use select (select_transcripts and select_samples) as it is mainly acting on columns so would select be more in line with tidyverse?
Although I wonder if some might think it's a function for subsetting/selecting transcripts/samples of interest? So could use select_transcript_columns and select_sample_columns to be clear or would that be too long?
But I don't have a strong preference here for pivot/subset/select.
[-]Replace pivot_* with subset_*[/-][+]Replace pivot_* with select_columns_*[/+][-]Replace pivot_* with select_columns_*[/-][+]`tidybulk` Replace pivot_* with select_columns_*[/+][-]`tidybulk` Replace pivot_* with select_columns_*[/-][+]`tidybulk` Replace pivot_* with subset_*[/+]stemangiola commentedon Mar 17, 2026
This has been done at the
tidySElevel.tidyomics/tidySummarizedExperiment#121
with
subset_feature_dataandsubset_sample_dataEventually, the current functions will be deprecated from tidybulk