Skip to content

Fix glmmSeq fits on lme4 2.1 - #352

Merged
stemangiola merged 1 commit into
masterfrom
fix/glmmseq-lme4-offset
Nov 8, 2026
Merged

stemangiola merged 1 commit into
masterfrom
fix/glmmseq-lme4-offset

Conversation

@stemangiola

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the numeric library-size offset on the formula environment so lme4 2.1 model.frame() no longer resolves offset to stats::offset().
  • Stop with the first gene-level error when every glmmSeq fit fails, instead of returning that text and crashing the vignette on @stats.
  • This unblocks the introduction vignette mixed-model chunk that is failing rworkflows on master.

Test plan

  • Confirm rworkflows rebuilds introduction.Rmd, including the glmmseq_lme4 chunk
  • Locally, with lme4 2.1, test_differential_expression(~ dex + (1 | cell), method = "glmmseq_lme4", formula_dispersion = ~ dex + cell) on a few airway genes returns finite p-values

Made with Cursor

lme4 no longer copies the numeric offset into the formula environment, so every gene fit failed and the vignette crashed on the returned error text.

Co-authored-by: Cursor <cursoragent@cursor.com>
@stemangiola
stemangiola merged commit 92b9c2d into master Nov 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant