fix: write create-project files inside the selected directory - #1
Open
tonycoder-hub wants to merge 2 commits into
Open
tonycoder-hub wants to merge 2 commits into
tonycoder-hub wants to merge 2 commits into
Conversation
Handlebars treats \{{ as an escaped literal, so compiling a Windows
fsPath turned empty-ability\{{moduleName}} into a sibling folder
named empty-ability{{moduleName}}. Compile the relative POSIX path
instead so the module lands inside the chosen save path.
Fixes ohosvscode#219
Co-authored-by: Tony Coder <407243179@qq.com>
The vite-plus test runner polyfills node:path without win32, so assert
the compiled relative path and the Handlebars \\{{ escape directly.
Co-authored-by: Tony Coder <407243179@qq.com>
tonycoder-hub
marked this pull request as ready for review
August 17, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ohosvscode#219.
Create-project was compiling each template file's full
fsPathwith Handlebars, then usingpath.relative(templateRoot, compiledPath)to decide the output location.That is not a Windows
pathbug. Handlebars treats\{{as an escaped literal{{. On Windows the separator before{{moduleName}}is\, so:compiles to:
path.relativethen yields..\empty-ability{{moduleName}}\..., andpath.resolve(savePath, that)writes a sibling of the directory the user selected. POSIX paths use/{{moduleName}}, so the same code works on macOS/Linux — which matches the maintainer note that this looked Windows-specific.Fix
Compile only the path relative to the template root, after normalizing separators to
/, then resolve that relative path against the chosen save directory. The module folder is nowsavePath/entry/...(or whatevermoduleNameis), notsavePath/../empty-ability{{moduleName}}/....Test
packages/vscode/test/project-template-path.test.tscovers POSIX and Windows-style template paths, and records the original Handlebars escape behavior.Notes
Does not touch ohosvscode#265 or overlap with ohosvscode#308.