Repository navigation
Conversation
What was broken The earlier Community App and opportunities fixes updated the MM dialogs, permissions, and ZIP downloads. QA still found a missing example artifact for active matches, mismatched icons, uncentered modal rows, unbolded labels, sort arrows on inactive columns, left-aligned ranks, and table scrolling. Root cause The filter expected the literal example ID, but the dev API returns IDs such as YtoH-k9To2Ggxx-example. Global CSS resets inherited label weight and cell alignment. Generic icons and a forced 1200px table width retained visual gaps. What was changed Accept the exact submission-prefixed example ID while retaining original identifiers for downloads and excluding internal or unrelated artifacts. Reuse the folded-page icons from the merged Community App implementation. Explicitly center modal cells and bold metadata labels. Show sort arrows only on active challenge-detail columns, align desktop ranks right, reserve compact action space, and size columns to the card instead of forcing a minimum table width. Keep long handles on one line with a full-handle title. Preserve completed-match ZIP downloads, permissions, and modal navigation. Update the opportunities README. Any added/updated tests Add two regressions for prefixed example downloads and access changes. Use prefixed IDs in the ZIP-content test and verify active-only arrows in all six existing derived-column sorting cases. Update the icon assertion. All 65 opportunities suites and 814 tests pass. Lint, production build, and headless browser checks pass, including nine viewport widths, long handles, large history counts, modal styles, sorting, navigation, and real ZIP contents. The full suite has 398 passing suites and 2912 passing tests. Its 21 failed suites and 18 failed tests exactly match untouched dev at fc95c0f; no new failures were introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The earlier fixes (community-app #7290 and platform-ui #2532) refreshed the MM dialogs and added completion-gated artifact downloads and a single Download all ZIP.
QA still reported missing examples during active matches, incorrect artifact icons, modal text/icons sitting too high, labels without bold weight, arrows on unsorted columns, left-aligned ranks, and horizontal scrolling. QA also requested checks with long handles. Completed-match downloads were working and are preserved.
Root cause
The dev API returns submission-prefixed identifiers: the reported active submission returns
YtoH-k9To2Ggxx-example. The previous filter accepted only the literalexample. Global reset styles left metadata at normal weight and table cells baseline-aligned. The UI used generic document icons and forced the public MM table to at least 1200px wide.What was changed
exampleand the exact current submission's prefixed example ID. Preserve original IDs for individual and bulk downloads; continue excluding internal and unrelated IDs before completion.Fresh branch
PM-6628-2starts from currentdev(fc95c0f42), which includes both the prior opportunities implementation and subsequent merged work. No API or dependency changes.Files changed (11): the opportunities README; two SVG assets; SubmissionArtifactsModal component/styles/tests; SubmissionHistoryModal component/styles; and ChallengeDetailsPage component/styles/flow tests.
Any added/updated tests
Two new regressions cover real prefixed example IDs, exact download IDs/filenames, rejection of internal and unrelated IDs, and filtering after management access is removed. The existing ZIP test now uses prefixed IDs. Six existing sorting cases assert that only the active header has an arrow; the action test checks the decorative SVG.
Validation used Node 22.13.0 via
nvm use:yarn lint: passed.NODE_OPTIONS=--max_old_space_size=8192 yarn run build: passed.yarn test:no-watch --runInBand: all 65 opportunities suites and 814 tests passed. Repository-wide results are 398 passing suites and 2912 passing tests, with 21 failed suites and 18 failed tests. A full run on untoucheddevatfc95c0f42reproduces exactly the same failed suite and test names (2910 passing tests). Existing failures outside opportunities require separate fixes before the full repository suite is green.git diff --check: passed.Commit and PR bodies use real newlines and paragraph breaks.