Repository navigation
test: Fix L0_long_running_stress - #9052
Merged
yinggeh merged 1 commit intoNov 5, 2026
Merged
Conversation
The high-queue check used the 10 ms lower bound, so any queue above 10 ms lowered concurrency and the 100 ms upper bound was unused. Compare against the upper bound. Build the report with HRuleStyle when prettytable provides it, and print client.log once when the stress process fails. Keep test_util as the only import below sys.path, since it is the only module loaded from qa/common. Signed-off-by: Yingge He <yinggeh@nvidia.com>
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryThe PR fixes the queue threshold used by
No actionable issues were found. The full stress test was not run. Reviews (1) · Last reviewed commit: "test: Hold stress concurrency inside the..." · Reviewed by Greptile |
Vinya567
self-requested a review
November 2, 2026 22:55
Vinya567
approved these changes
Nov 2, 2026
yinggeh
deleted the
yinggeh/tri-2050-ci-l0_long_running_stress-base-failing
branch
November 5, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
L0_long_running_stress now lowers perf_analyzer concurrency only when the measured server queue is above the 100 ms upper bound. A queue between 10 ms and 100 ms leaves concurrency unchanged. The summary report uses
prettytable.HRuleStylewhen that API is present, so generating the report does not emit the deprecatedprettytable.ALLwarning.The same two files also clear pre-existing flake8 findings so the pre-commit check can run on this change: explicit scenario imports, import-order exceptions after
sys.pathsetup, and comparison style.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
None.
Where should the reviewer start?
qa/L0_long_running_stress/scenarios.pyqueue comparison, thenqa/L0_long_running_stress/stress.pyreport table.Test plan:
pre-commit run --files qa/L0_long_running_stress/scenarios.py qa/L0_long_running_stress/stress.pyRun
L0_long_running_stressand confirm a queue between 10 ms and 100 ms does not change concurrency, a queue above 100 ms lowers it, and the client log has noprettytable.ALLdeprecation warning.CI Pipeline ID:
Caveats:
No GitHub issue is linked. The flake8 edits do not change scenario behavior beyond the queue bound and the report-table API.
Background
The target queue range is
(10000, 100000)microseconds. The high-side comparison used index 0, the same 10 ms value as the low-side comparison, so the 100 ms bound was unused.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
None.