Skip to content

build: Include THIRD-PARTY-NOTICES.txt in containers (#9057) [r26.11] - #9059

Merged
mc-nv merged 1 commit into
r26.11from
devin/1793751725-notices-r26.11
Nov 4, 2026
Merged

mc-nv merged 1 commit into
r26.11from
devin/1793751725-notices-r26.11

Conversation

@mc-nv

@mc-nv mc-nv commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

Cherry-pick of #9057 (af26fdce) to r26.11:

  • Install THIRD-PARTY-NOTICES.txt into /opt/tritonserver/ via build.py (full, vllm and rhel-zip images)
  • Copy it in compose.py for composed images
  • Copy it, with LICENSE, into the SDK image and its clients tarball (Dockerfile.sdk)
  • OSRB requires the file inside every NGC image after the one-time 26.10 exception

Applied cleanly with git cherry-pick -x.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • build.py and compose.py

Test plan:

  • Image build shows /opt/tritonserver/THIRD-PARTY-NOTICES.txt and /workspace/THIRD-PARTY-NOTICES.txt (SDK)
  • CI Pipeline ID: pending

Caveats:

  • Builds fail if THIRD-PARTY-NOTICES.txt is missing from the branch (it is present on r26.11)

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: TRI-2139

Requested by: @mc-nv

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The changes affect the contents of Triton server and SDK packages.

Fix composition from older source images before merging.

Findings

  1. P1 Older source images fail ▶

Summary

Adds third-party notices to server installs, composed images, and the SDK.

  • Server images now include the third-party notices file.
  • The SDK image and clients archive include both license files.

Reviews (1) · Last reviewed commit: "build: Include THIRD-PARTY-NOTICES.txt i..." · Reviewed by Greptile

Comment thread compose.py Resolved
@mc-nv
mc-nv merged commit eb11daa into r26.11 Nov 4, 2026
5 checks passed
@mc-nv
mc-nv deleted the devin/1793751725-notices-r26.11 branch November 4, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants