You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any movement on this? It'd be nice to be able to install this like more traditional type libraries; alternatively the types here could be added to the core mysql2 library via PR if you're alright with that.
@felixfbecker This is your decision 😄 It might make sense to authorize someone to copy the definition and hand off maintenance to DefinitelyTyped.
For everyone here, note that a lot of people in @types spent a lot of time creating high quality definitions that ultimately were incompatible with the TypeScript operating model because we don't want to work on DefinitelyTyped (hard to iterate, hard to respond to issues, giant mono repo lacking individual ownership, etc) and this resulted in a lot of burn out (especially personally, I dropped OSS for the past year).
@blakeembrey I feel you for sure on your issues with DT; that's why personally I prefer moving the definitions from here over into the actual mysql2 library. Assuming @sidorares is comfortable with that addition to the repository, I generally feel that including types with the actual package is a superior option to any external source of truth; see the neverending discussion around the Stripe library's types for an example of why.
Reacted by Blake Embrey, adam-b-maurer, Homa Wong, Torgny Bjers, Pavlo and sanchopancho13
Worth noting that, as things are now, that would mean including @types/mysql as an added dependency for mysql2. If that's not an issue then we should be good to go on this.
It sounds like we've got a green light from everybody involved, and are just waiting on someone to make a PR. Is this correct @sidorares@felixfbecker?
Types for mysql2 will be needed on a large project that I'm helping modernize, so I can champion this.
As ISC and MIT are largely compatible (IANAL but this is a widely held perspective), we can probably just embed this entire codebase in a types directory and add both licenses to the mysql2 license file. However, for the sake of simplicity, @felixfbecker would you mind re-licensing this under MIT (again, IANAL but attestation here is probably sufficient) and allow us to simply use the mysql2 license as written (given its existing "and contributors" copyright) or perhaps just add your name to the copyright?
Activity
dashmug commentedon Dec 4, 2017
I agree.
moberemk commentedon Feb 21, 2018
Any movement on this? It'd be nice to be able to install this like more traditional type libraries; alternatively the types here could be added to the core mysql2 library via PR if you're alright with that.
tbjers commentedon Mar 15, 2018
+1
breitsmiley commentedon Mar 18, 2018
+1
blakeembrey commentedon Mar 19, 2018
@felixfbecker This is your decision 😄 It might make sense to authorize someone to copy the definition and hand off maintenance to DefinitelyTyped.
For everyone here, note that a lot of people in @types spent a lot of time creating high quality definitions that ultimately were incompatible with the TypeScript operating model because we don't want to work on DefinitelyTyped (hard to iterate, hard to respond to issues, giant mono repo lacking individual ownership, etc) and this resulted in a lot of burn out (especially personally, I dropped OSS for the past year).
moberemk commentedon Mar 19, 2018
@blakeembrey I feel you for sure on your issues with DT; that's why personally I prefer moving the definitions from here over into the actual mysql2 library. Assuming @sidorares is comfortable with that addition to the repository, I generally feel that including types with the actual package is a superior option to any external source of truth; see the neverending discussion around the Stripe library's types for an example of why.
sidorares commentedon Mar 19, 2018
@moberemk @blakeembrey yes, happy to have type definitions in repo
dashmug commentedon Mar 19, 2018
Best news I read this morning! Thanks @sidorares!
moberemk commentedon Mar 20, 2018
Worth noting that, as things are now, that would mean including
@types/mysqlas an added dependency formysql2. If that's not an issue then we should be good to go on this.melroy89 commentedon Aug 18, 2018
Any update?
sidorares commentedon Aug 19, 2018
@Danger89 I haven't done anything myself. Happy to review PRs on this
Kosta-Github commentedon Sep 20, 2019
any updates on this one? would be very much appreciated!
mike-marcacci commentedon Oct 3, 2019
It sounds like we've got a green light from everybody involved, and are just waiting on someone to make a PR. Is this correct @sidorares @felixfbecker?
Types for mysql2 will be needed on a large project that I'm helping modernize, so I can champion this.
As ISC and MIT are largely compatible (IANAL but this is a widely held perspective), we can probably just embed this entire codebase in a
typesdirectory and add both licenses to the mysql2 license file. However, for the sake of simplicity, @felixfbecker would you mind re-licensing this under MIT (again, IANAL but attestation here is probably sufficient) and allow us to simply use the mysql2 license as written (given its existing "and contributors" copyright) or perhaps just add your name to the copyright?felixfbecker commentedon Oct 3, 2019
You're welcome to do whatever with it. Pretty sure ISC and MIT are equivalent.
sidorares commentedon Oct 4, 2019
@mike-marcacci yes, I'm just observer here, happy to merge types if quality looks good enough but I'm not the best person to author