Fix authorization errors reversing current and allowed roles - #969
Draft
HarshMN2345 wants to merge 1 commit into
Draft
Fix authorization errors reversing current and allowed roles#969HarshMN2345 wants to merge 1 commit into
HarshMN2345 wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Denied authorization messages identified the last allowed role as the caller, then reversed the current and allowed role lists. Report the caller’s complete role list and the resource’s allowed roles in the correct positions. Permission checks themselves are unchanged.
The regression covers multiple allowed roles, a guest caller, and a caller with no roles. It fails against the original implementation and passes with the fix. Focused authorization tests pass (three tests, 30 assertions), as do Pint and targeted PHPStan level 7.
Fixes appwrite/appwrite#7201.