Skip to content

fix: add explore's CSP and fix docs search and previews - #10951

Merged
lwwmanning merged 1 commit into
developfrom
wm/web-fixes
Oct 29, 2026
Merged

lwwmanning merged 1 commit into
developfrom
wm/web-fixes

Conversation

@lwwmanning

Copy link
Copy Markdown
Contributor

This PR fixes four small problems on the docs and explore sites:

  • explore had no security headers. It now sends a CSP. The CSP allows the wasm module, Google Fonts, the worker, and the https URLs that users open.
  • On preview deployments, the Vercel toolbar was blocked. Previews now allow its sources. The production domains keep the strict policy.
  • Docs search did not finish. The theme now marks its main content with role="main", which Sphinx search requires.
  • Javadoc pages requested a font file that JDK 17 does not make. The docs build now removes that request.

I tested each change on preview deploys in a browser.

🤖 Generated with Claude Code

- explore had no security headers. It now sends a CSP plus the
  nosniff, referrer and opener headers the docs send. The CSP allows the
  wasm module ('wasm-unsafe-eval'), Google Fonts, the explorer's worker,
  and fetches of any https: URL, because users open remote files by URL.
- Preview deployments of docs and explore now also allow the sources
  the Vercel toolbar needs (vercel.com/docs/vercel-toolbar), so comments
  work on previews. The rules use a `missing` host condition, so
  docs.vortex.dev and explore.vortex.dev keep the strict policy.
- The docs theme's <main> element now has role="main". Sphinx search
  queries [role=main] to build result snippets. Without it, search
  never finished and logged an error for each result.
- JDK 17's javadoc stylesheet imports a font file that JDK 17 never
  generates. The docs build now removes that import, so each javadoc
  page stops requesting a missing file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning lwwmanning added the changelog/fix A bug fix label Oct 28, 2026
@codspeed

codspeed Bot commented Oct 28, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.4%

4 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 1 benchmark

This benchmark measured no execution time, so its result is not comparable and counts as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 2272 untouched benchmarks
⏩ 370 skipped benchmarks1
🗄️ 30 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation filter_powerlaw_by_correlated_runs[100000] 51.2 µs 61 µs -15.96%
⚡ Walltime lt_i64_nullable_avx512 8.1 µs 7.3 µs +11.05%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wm/web-fixes (0715c7d) with develop (40e0b1c)

Open in CodSpeed

Footnotes

  1. 370 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 30 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T05:39:49.208356Z 0715c7d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lwwmanning
lwwmanning merged commit c84e489 into develop Oct 29, 2026
110 of 112 checks passed
@lwwmanning
lwwmanning deleted the wm/web-fixes branch October 29, 2026 09:21

This branch was successfully deployed

2 active deployments
vercel-explorer — 0715c7df Deployed Oct 28, 2026 by lwwmanning via Deploy to Vercel / Deploy #16538
vercel-docs — 0715c7df Deployed Oct 28, 2026 by lwwmanning via Publish preview / Deploy #6195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants