Repository navigation
Conversation
|
@AK-Reid, automation “GitHub PR opened” in factory “warp-terminal-factory” couldn’t start a run. The Warp account linked to your GitHub account isn’t on team “Warp / Stanford”.
|
Author
|
@warp-factories please review this PR. I have corrected the Warp account connection and am retrying the review. |
Author
|
/warp-agent-review |
1 similar comment
Author
|
/warp-agent-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With left vertical tabs and hover details enabled, a pane's details card could remain above View options, cover the Tabs control, and block its click. Opening View options now uses the existing sidecar cleanup path so the menu stays accessible and stale hover content does not return when it closes.
The production change only extends the existing suppression guard. Selection handlers, preferences, and shared UI components are unchanged.
Linked Issue
Related to warpdotdev#9180.
The older duplicate-popup cause was already fixed upstream in warpdotdev#9540. This PR addresses the narrower hover-card overlap reproduced on the current Stanford baseline; it does not claim to reproduce every failure in the original report.
ready-to-specorready-to-implement.Testing
Added a regression test using the real sidecar renderer and a workspace fixture. It verifies suppression and target cleanup while the menu is open, no stale card after closing, and rendering after a fresh hover target. Confirmed the test fails on the unfixed renderer at the popup-open assertion.
All 88 targeted vertical-tabs tests passed.
GUI build and targeted Clippy for all targets/tests passed with
-D warnings.Ran
./script/formatand inspected the final diff;git diff --checkpassed.Manually exercised two complete cycles per theme in Dark and Light: pane/tab hover, menu opening, Panes/Tabs selection, dismissal, and expanded/compact density. An independent agent visually reviewed all 40 captured states with no mismatches, including no stale card in all 24 popup-visible frames.
I have manually tested my changes locally with
./script/run.Visual checks used macOS with the WGPU renderer. Native Metal, other platforms, the reporter's exact older environment, resized windows, and held mouse input were not verified.
Screenshots / Videos
Left: the unfixed hover card covers Tabs and blocks its click. Right: the fixed build clears the card and the same Tabs click succeeds.
Agent Mode
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Fixed hover details covering the vertical-tabs View options menu and blocking clicks.