Repository navigation
Add tests for string offset arithmetic and StringRange - #51
Open
zubincarvalho wants to merge 1 commit into
Open
zubincarvalho wants to merge 1 commit into
zubincarvalho wants to merge 1 commit into
Conversation
|
@zubincarvalho, automation “GitHub PR opened” in factory “warp-terminal-factory” couldn’t start a run. The Warp account linked to your GitHub account isn’t on team “Warp / Stanford”.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of warpdotdev/warp#ISSUE_NUMBER
Adds 6 unit tests to crates/string-offset/src/lib_tests.rs covering CharOffset/ByteOffset arithmetic (Add, Sub, AddAssign, SubAssign, Display), add_signed with positive and negative deltas, CharOffset's i32 AddAssign, saturating_sub including underflow to zero, range and empty_range, and StringRange::extend_range_end, including that a shorter range never shrinks the current one for both char and byte offsets.
Testing: cargo test -p string-offset passes 11/11 plus the existing doctest.