Repository navigation
Discussion: Use native shell autocompletion #59
Description
Is your feature request related to a problem? Please describe.
Ex. I'm always frustrated when autocomplete doesnt work.
Eg:
touchTAB doesnt work~/preTAB doesnt work (should expand to~/prefixninja insTAB completes toninja install_manifest.txt, notninja installcd rustdTAB completes tocd rustdoc/, notcd rustdoc, where I can then specify I wanted to go torustdoc-json, (in rustcsrc/testdirman claTAB doesn't comlete (zsh shows clang clang++ clang++-12 clang-12 classes.conf)
Describe the solution you'd like
I'd like to be able to deligate to the underlying shell to provide autocompletion.
Reacted by Jeremy Klein, Maxim Krouk, Dave Combs, James Grant, elvis kahoro, Luka Pajukanta, Ulrich Hinze, Greg Antrim, I. A. Naval, Julien Sudan and 1 more
Activity
zachlloyd commentedon Jul 23, 2021
Makes sense as a request.
Our current approach is to try move this logic into Warp by building out our own completion grammar and library, with the rationale being:
That said, we are missing a bunch of context right now from the shell which is making our completions worse than they should be. And we just have a number of bugs. I think we will see how far we can get without delegating to the shell, and add that as a fallback if we can't make it great.
Thanks for the report.
aDotInTheVoid commentedon Jul 23, 2021
Maybe a hybrid aproach works best, where if you know about a tool (npm, etc) you provide native support, but if not, you can delegate to the underlying shell (ninja, r2, rg etc).
Some of the more basic stuff (starting with
~or/, completingtouch) should definatly be fixed in your layerzachlloyd commentedon Jul 24, 2021
Yup, we will explore that. We actually started with an approach of delegating the shell, but it did introduce extra latency. As a fallback though it might be acceptable. Appreciate the feedback.
simjnd commentedon Jul 28, 2021
Completion using variables is also broken, e.g.
ls $HOME/Dowexpands the variable and autocompletes tols /Users/simjnd/Downloadsbut it doesn't work in Warpjklein24 commentedon Jul 29, 2021
Throwing my +1 into the mix on this that the autocomplete issues definitely hinder my ability to use Warp as a primary driver right now. I also source an open source git_completion.sh script to get autocomplete for git branches and commands, but that doesn't seem to work with warp either. Would definitely like a fallback to native autocompletion when warp has no suggestions.
maximkrouk commentedon Aug 1, 2021
I think the lack of
makeautocompletion is related too.Otherwise I may open another feature-request to support
make🙂davecombs commentedon Aug 7, 2021
While it's a beta (and pretty impressive so far - I find very little of what it actually does that I don't like a lot!), not having some sort of command completion at least for filenames working is really going to make things difficult to continue. Maybe my setup (bash) is interfering, but even just '. ~/.bash_al' doesn't do anything - no list of files, no default pick, nothing. I have no choice but to retype in the file name completely. Anybody reported anything in bash that might interfere with what you're building (so I could at least get the minimal file completion?)
nesl247 commentedon Aug 23, 2021
I definitely think that the shell needs to take precedence here over any autocompletion by the terminal. I have my shell configured exactly how I want it to be, with the autocomplete that I want it to have. Regardless of if I'm using Warp, iTerm2, Terminal.app, or any other terminal, I don't want to have a difference experience. The terminal should enhance the shell, not replace it.
[-]Use native shell autocomplettion[/-][+]Completions: Use native shell autocomplettion[/+][-]Completions: Use native shell autocomplettion[/-][+]Completions: Use native shell autocompletion[/+]ned-si commentedon Nov 8, 2021
+1 for this!
Having default autocompletion included in the terminal is fine, but I think that users must have the ability to customize it exactly the way they want is very important.
Being able to simply use what was already made at the shell level would be best, but another acceptable possibility, imo, would be to be able to customize it with a config file for Warp.
As someone else mentioned already, this is the single thing that prevents me to daily test Warp.
[-]Completions: Use native shell autocompletion[/-][+]Discussion: Use native shell autocompletion[/+]