Repository navigation
Verify the release MSI without installing it - #105
Closed
willibrandon wants to merge 1 commit into
Closed
willibrandon wants to merge 1 commit into
willibrandon wants to merge 1 commit into
Conversation
The win-x64 release job runs on the dedicated Windows runner as NETWORK SERVICE. Windows Installer's COM server only lets Administrators, interactive users, and SYSTEM launch it, so msiexec failed with 1601 before doing anything, and a per-machine install would need admin rights anyway. The step now decompiles the MSI in process with WiX, checks that it installs to Program Files\scout and adds that folder to the system PATH, compares every packaged file with the stage, and runs the packaged scout.exe.
willibrandon
added
packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 39521216541 failed in the win-x64 MSI check with msiexec exit 1601. That job runs on the dedicated Windows runner as NETWORK SERVICE, and the Windows Installer COM server only lets Administrators, interactive users, and SYSTEM launch it, so msiexec could not reach the service at all. A per-machine install would also need admin rights on the host.
The step now decompiles the MSI in process with WiX, which never touches the installer service. It checks that the package installs to Program Files\scout and adds that folder to the system PATH, compares every packaged file against the stage by hash, and runs the packaged scout.exe. I ran it on the runner host against a 0.8.0 MSI with the installer service stopped and it stayed stopped. A tampered or extra stage file fails the check as expected.