Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicitly supplied empty regex is valid and matches every value.
csvgrepcurrently tests the argument's truthiness, falls through to a missing string pattern, and removes the pattern from its filters. As a result,csvgrep -a -c 1,2 -r '' examples/dummy.csvemits only the header, while adding-iincorrectly emits the data row.Distinguish an absent regex (
None) from an empty one and compile both empty and nonempty regexes through the same path. This keeps filtering semantics consistent between all/any-column matching and inversion. Includes four regression combinations and an Unreleased changelog entry. No new option or dependency.Validation on Linux / Python 3.12.14:
TestCSVStat.test_decimal_format(9748.346vs9,748.346), also reproduced on clean upstream baseeefcd0ef72747ebf7e9086987ff267291ad877faduring this contribution session.AI-assisted implementation and local verification. Checked existing open PRs for duplicates.