Repository navigation
Port upstream Host handling and update dependencies - #46
Merged
Merged
Conversation
Why this change was needed: This fork was behind upstream and had a concrete upstream request-building fix worth carrying over. While checking upstream changes, the dependency graph also had safe updates available within the repo's Go 1.21 floor. What changed: - Use the last repeated Host header value when building requests. - Add regression coverage for repeated Host headers. - Update http2curl to v2 and refresh module metadata. - Upgrade compatible go.mod dependencies without raising the Go floor. Problem solved: The request builder now matches upstream behavior for repeated Host headers, and the module graph is less stale without requiring callers to move past Go 1.21.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: Go 1.21/1.22 compile-only checks passed locally, but executing those downloaded toolchain test binaries on this Mac hit a dyld loader issue before package code ran.