Repository navigation
Conversation
…rced end-to-end (XWPENG-46). Replace shutdown echo with capability-gated admin notices, bump release to 5.0.0, and quiet PHPUnit multisite noise from headers and Yoast indexables.
Config-only: require-dev pin, on-demand composer scripts, cache under artifacts/, PHPCS exclude for cache dir. No plugin source changes.
Register TypedPropertyFromAssignsRector with extension-point base skips; hand-correct Plugin service holders and Connectors_Unit_Test Admin mock fidelity.
… contract (XWPENG-47). Guard the three wp_stream_settings_* filter boundaries in Settings so a misbehaving callback can never feed null or a non-array into properties that the typed-property Rector runs assign to directly: - get_option_key(): fall back to the computed key when the wp_stream_settings_option_key filter returns a non-string. - get_options(): fall back to the unfiltered options array when the wp_stream_settings_options filter returns a non-array. - get_fields(): keep the unfiltered fields when the wp_stream_settings_option_fields filter returns a non-array. These props are untyped today only because Rector skipped them due to the mixed filter assignments; any consumer with typed properties (or a future TypedPropertyFromAssigns run) would otherwise throw a TypeError on every request, since Settings is constructed on init. Also declare the DB_Driver::setup_storage() return type (Install) on the interface and the WPDB implementation. Plugin::$install is nullable-typed in this stack, so a custom wp_stream_db_driver driver returning anything else previously failed with a cryptic runtime TypeError; it now fails at class-load time inside the offending driver. Note: the setup_storage signature is technically breaking for third-party drivers that omit the return type.
Rector plus hand invariance alignment so parent and child property types match. Connector::$name is string (non-nullable) on the base and every child.
Rector plus hand invariance alignment; remove typed-property skip list from rector.php.
Seventeen constructors across connectors, alerts, and exporters; hand-correct Connectors_Unit_Test Admin mock fidelity.
Rector plus hand review in class-alerts.php and class-connectors.php.
Move side-effecting bootstrap into boot() after locations are set; the constructor still calls boot() so hook timing is unchanged. Add Plugin_Test coverage for actions registered in boot() and filter side effects.
shadyvb
changed the title
shadyvb
marked this pull request as ready for review
September 6, 2026 20:27
7 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes XWPENG-48.
Stacks on #1986 (
ticket/XWPENG-47-match).Extracts
Plugin::boot()fromPlugin::__construct()so location setup (needed before the autoloader can resolve plugin classes) stays in the constructor while dependency loading, subsystem instantiation, and hook registration move into a dedicatedboot()method. Hook names, priorities, and registration order are unchanged — this is a structural refactor only, intended to make the boot sequence easier to test and to prepare for later god-class splits.Summary
Plugin::__construct()— sets$this->locations, then calls$this->boot().Plugin::boot()— new public method containing the former constructor body after location setup: autoloader registration, scheduler selection, DB driver wiring,add_actioncalls, admin/install bootstrap, and WP-CLI registration.__construct()toboot()where timing semantics apply (Action Scheduler availability,wp_stream_use_action_schedulerfilter).test_boot_registers_expected_actions()asserts the fouradd_actionregistrations;test_boot_applies_expected_filters()assertsdb,log, andschedulerare instantiated with expected types.Test plan
composer lintandcomposer lint-testspass locallyChecklist
contributing.md).Release Changelog
Release Checklist
masterbranch.readme.txt.stream.php.Stable taginreadme.txt.classes/class-plugin.php.Change
[ ]to[x]to mark the items as done.