Repository navigation
Conversation
Every subcommand in __zinit_commands now has a handler; removes dead helpers no command maps to.
3 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Audits every
# FUNCTION:marker and user-visible string in_zinit(9 hunks, all in the one file):
# FUNCTION: _zinit_debugmarker (_zinit_debugwas the onlyblock-style function without one; every command↔function mapping was
validated —
cdlist→_zinit_cdlistincluded)._messagestrings that all wrongly readlist the defined key bindings replay, using each command's owndescription: bindkeys, report (
show plugins report), load(
load a plugin).a plugins→a plugin,plugins source→plugin's source,apend→append,get list→get the list,trailing space trimmed on the
recallentry.Deliberately left out (needs maintainer wording, not guessed):
recall's truncated description (...and construct— what?),srv'sControl a service, commandcomma, the terseStressmessage,and a marker for the conditional one-liner
_zinit_debug_cmds(a[[[fold marker would mis-fold there).How did you verify your code works?
zsh -n _zinit— syntax OK (on the exact branch bytes).# FUNCTION: name [[[in the file matched againstthe
name(){definition that follows it; every entry in__zinit_commandschecked for a corresponding_zinit_<name>functionand vice versa.
main: exactly these hunks— nothing else changed, nothing deleted.
Checklist
Related work
Spun out of the nounset audit for #842 / #843
(the
_zinitnounset guard itself lives in #843).