Repository navigation
Conversation
Allow the `url` property to be omitted from board, shield, and interconnect metadata. Update the supported hardware list to render the hardware name as plain text when no URL is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
urlproperty to be omitted from board, shield, and interconnect metadata.For a lot of one-off custom keyboards, there's not really a page for them. For these configs people usually use the zmk-config themselves as the url, or leave url empty/missing.
zmk-cli already uses
str | Noneforurl.ZMK docs hardware list also changed in this PR.
I'm not aware of any other ZMK metadata consumer.
PR check-list