Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each failed
connect()attempt registers another copy of the native event and delivery callbacks. After brokers become reachable, one produced message can emit several identical delivery reports. Remove the failed attempt's callbacks before returning its error so the next attempt registers one copy.Fixes #1143.
Validation: the new regression uses librdkafka's in-process mock cluster and the real native addon, injecting three initial metadata failures. It receives four reports for one message on current master and one with the fix, then disconnects and reconnects the same producer and verifies one report for its next message.
npm testpasses all 104 tests on Node 22.23.2/Linux. The native addon builds with two jobs. The new test passes JSHint;make jslintretains preexisting findings, including the same missing semicolons atlib/client.js:65and:70on master.This is an in-process mock broker and injected metadata-failure test, not testing against a deployed Kafka cluster. Native Windows/macOS and the other Node versions were not run locally.