Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ Client.prototype.connect = function(metadataOptions, cb) {

var next = function(err, data) {
self._isConnecting = false;
if (err) {
// A failed attempt must not leave callbacks registered for the next one.
self._client.configureCallbacks(false, self._cb_configs);
}
if (cb) {
cb(err, data);
}
Expand Down
115 changes: 115 additions & 0 deletions test/reconnect.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
/*
* node-rdkafka - Node.js wrapper for RdKafka C/C++ library
*
* Copyright (c) 2016 Blizzard Entertainment
*
* This software may be modified and distributed under the terms
* of the MIT license. See the LICENSE.txt file for details.
*/

var Producer = require('../lib/producer');
var t = require('assert');

module.exports = {
'Producer reconnect': {
'does not duplicate delivery reports after failed connections': function(cb) {
this.timeout(30000);

// librdkafka's in-process mock cluster exercises the real native callback
// dispatcher and delivery reports without an external Kafka service.
var client = new Producer({
'test.mock.num.brokers': 1,
'dr_cb': true
});
var metadata = client.getMetadata;
var failure = new Error('metadata request failed');
var attempts = 0;
var reports = 0;

client.on('delivery-report', function(err) {
t.ifError(err);
reports++;
});

client.getMetadata = function(options, next) {
// Fail after the native connection has been created, as happens when
// brokers remain unreachable during the initial metadata request.
setImmediate(function() { next(failure); });
};

function finish(err) {
client.disconnect(function() { cb(err); });
}

function produce(expected) {
var flushed = false;
var delivered = false;

function verify() {
if (!flushed || !delivered) {
return;
}

// Let the native dispatcher finish calling every registered copy.
setImmediate(function() {
try {
t.strictEqual(reports, expected);
} catch (e) {
return finish(e);
}

if (expected === 2) {
return finish();
}

client.disconnect(function() {
client.connect({}, function(err) {
if (err) {
return finish(err);
}
produce(2);
});
});
});
}

client.once('delivery-report', function() {
delivered = true;
verify();
});
client.produce('reconnect', 0, Buffer.from('message'));
client.flush(5000, function(err) {
if (err) {
return finish(err);
}
flushed = true;
verify();
});
}

function connect() {
client.connect({}, function(err) {
if (++attempts <= 3) {
try {
t.strictEqual(err.message, failure.message);
} catch (e) {
return finish(e);
}

if (attempts === 3) {
client.getMetadata = metadata;
}
return connect();
}

if (err) {
return finish(err);
}
produce(1);
});
}

connect();
}
}
};