[core] Fixed remaining problems with data races - #3381
Merged
Merged
Conversation
This was
linked to
issues
Sep 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3381 +/- ##
===========================================
- Coverage 71.12% 53.99% -17.13%
===========================================
Files 101 115 +14
Lines 19776 25337 +5561
Branches 0 3896 +3896
===========================================
- Hits 14065 13681 -384
- Misses 5711 10237 +4526
- Partials 0 1419 +1419 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
stop()andclose()onCChannel. The multiplexer now callsstop()before stopping the queue worker threads, and then callsclose()after making sure that these threads have exit. This avoids potential outdated use of the socket descriptor value by the receiver worker thread after another thread has closed it.