Skip to content

ROU-13041: Document that the Storybook Theme toggle is the only gate on a classic-theme port #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-giulianasilva merged 17 commits into from
Oct 16, 2026
Merged

ROU-13041: Document that the Storybook Theme toggle is the only gate on a classic-theme port #1285

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fe629d0
ROU-13041: add ADR-0011 — functional-test and Chromatic ownership split
OS-giulianasilva Oct 6, 2026
0517b4a
ROU-13041: add a consolidated action-items table to ADR-0011
OS-giulianasilva Oct 6, 2026
c07ac89
ROU-13041: put the action items on the Confluence summary page
OS-giulianasilva Oct 6, 2026
673f8bf
ROU-13041: drop the Confluence summary source from the repo
OS-giulianasilva Oct 6, 2026
ea1c2f6
ROU-13041: drop the deliverable-shape decision and all internal links
OS-giulianasilva Oct 6, 2026
9764393
ROU-13041: close Q9 and Q12 in ADR-0011 — both confirmed
OS-giulianasilva Oct 6, 2026
c223244
ROU-13041: withdraw the chromatic.yaml hardening move from ADR-0011
OS-giulianasilva Oct 6, 2026
e9ce751
ROU-13041: state in the port skill that the theme toggle is the only …
OS-giulianasilva Oct 6, 2026
605462b
ROU-13041: drop Q15 from ADR-0011
OS-giulianasilva Oct 6, 2026
6fef2fc
ROU-13041: raise adoption of the Playwright rewrite as an open questi…
OS-giulianasilva Oct 6, 2026
a6b5f70
ROU-13041: reframe the Playwright evaluation as conditions, not a ver…
OS-giulianasilva Oct 6, 2026
7713504
ROU-13041: trim D4a, define the Q numbers, explain the D3 gap
OS-giulianasilva Oct 6, 2026
1f4dbd1
ROU-13041: condense ADR-0011 - tables over prose, dedupe repeated facts
OS-giulianasilva Oct 6, 2026
31d7cd0
ROU-13041: fold D1e-1 into a paragraph inside D1e
OS-giulianasilva Oct 6, 2026
a184ee6
ROU-13041: correct the working-documents claim in ADR-0011
OS-giulianasilva Oct 6, 2026
874c49b
ROU-13041: name the four evidence documents in the Links section
OS-giulianasilva Oct 6, 2026
2e0dc05
ROU-13041: Move ADR-0011 to outsystems-ui-tests and repoint the port …
OS-giulianasilva Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .claude/skills/osui-classic-theme/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,31 @@ grep -n 'app-menu-content\|app-login-info\|main-content' classic-theme/ODC.OutSy

A ported rule targeting a class the old theme never emits is dead CSS; say so rather than shipping it silently.

### That Theme toggle is the only gate on a port

Everything else in this repository is covered by CI. **A port is not.** Nothing automated will catch
a mistake here:

| | Covers a port? |
| :-- | :-- |
| Functional tests | **No** — their tags are derived from changed folders under `src/scripts/**` and `src/scss/04-patterns`, so a classic-only change runs none |
| Chromatic | **No** — it photographs the new-theme bundle; no story loads `classic-theme/` CSS |
| `npm run build` | **No** — compiles `src/` → `dist/` |
| `npm run lint` | **No** — covers `.ts`; these are CSS |
| A compiler | **No** — there is no SCSS behind `classic-theme/` to validate |

So if you skip the visual check, a broken port ships and **nothing reports it**. Do not treat §8 as
a formality — it is the whole safety net. (Recorded as a decision in ADR-0010 of the
`OutSystems/outsystems-ui-tests` repository, `docs/adr/ADR-0010-Split-Functional-Test-And-Chromatic-Ownership.md`, §D2.)

Two limits of the toggle, so it is not trusted further than it goes:

- **It loads the ODC bundle only.** `classic-theme/O11.OutSystemsUI.css` is served but never linked,
so the toggle validates **half** of a port. Verify the O11 edit by reading the diff.
- **It is a hybrid, not the classic theme.** `classic-theme/` has no JavaScript and
`preview-head.html` always loads the new theme's JS, so "Classic theme" is new-theme *runtime*
plus old-theme *CSS*. Sound as a CSS-regression check; it is not "the classic theme under test".

## 9. What not to do

- Don't hand-edit `src/scss/O11.OutSystemsUI.scss` / `ODC.OutSystemsUI.scss` (regenerated every build) — unrelated files, easy to confuse by name with the `classic-theme/` ones.
Expand Down
Loading