Repository navigation
build: spotbugs-maven-plugin 4.10.5.0, JLine 4.4.8, JSpecify nullness on Lombok code; llama.cpp b11558 -> b11574 - #533
Merged
Conversation
… on Lombok-generated code SpotBugs 4.10.5 understands JSpecify's @NullMarked and reported NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION on 27 Lombok-generated equals(Object) methods: under @NullMarked their unannotated parameter reads as non-null while Object.equals accepts null -- a wrong contract in the published bytecode, not a false positive. `lombok.addNullAnnotations = jspecify` in the shared lombok.config makes Lombok write @nullable on the equals/canEqual parameter (and @nonnull where a generated member cannot take or return null); verified from a clean build: Error Prone, NullAway and the Checker Framework compile green and spotbugs:check reports 0 bugs (javap shows org.jspecify.annotations.Nullable on Pair.equals). The siblings' copies of lombok.config and the policy follow in their own pull requests (shared file, manifest rewritten here). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
bernardladenthin
had a problem deploying
to
maven-central
October 12, 2026 21:10 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 12, 2026 21:10 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
startgate
October 12, 2026 21:10 — with
GitHub Actions
Error
This was referenced Oct 12, 2026
5 of 6 tasks
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
NP_METHOD_PARAMETER_TIGHTENS_ANNOTATIONon 27 classes -- under@NullMarkedthe parameter of a Lombok-generatedequals(Object)read as non-null whileObject.equalsaccepts null -- answered in the sharedllama/lombok.configwithlombok.addNullAnnotations = jspecifyrather than a suppression,.github/shared-files.sha256rewritten; the canonical copy is in the workspace policy); JLine 4.4.7 -> 4.4.8 inllama-atmosphere-agent(of its 604 classes onlyjansi/AnsiConsoleandshell/impl/HelpCommandsdiffer from 4.4.7, none of the files the eight carried JLine fixes touch; the agent compiles against it).tools/uifix the auto-followed WebUI picks up). What reaches this project: #30014 hides ggml's symbols by default in the sharedggml/ggml-base(BUILD_SHARED_LIBSonly, i.e. the modular library jars) -- verified by a local modular build:libggml-base.soexports 689 functions andlibggml.so16, the five the load path uses among them, and the model-free native Java tests ran over it (27/27, the RPC server resolved throughggml_backend_reg_get_proc_addressincluded); #30329 reports compute-graph reallocations (two appendedllama_perf_context_datafields and agraph reallocslog line per slot, no JSON change,Timings/getMetrics()untouched); #30378 / #30383 add two decision model types for/v1/systemone(vllm-decision2 with a strict payload, vllm-d3 with non-causal attention) behind an unchanged contract for the existing ones; #30095--kv-unifiedreaches the speculative example. Patch0012is refreshed onto #30299'stests/CMakeLists.txt(llama_build_and_test(... LINK llama)); the other eleven apply unchanged and every drop-check still finds its defect. Per-step rows indocs/history/llama-cpp-breaking-changes.md;CLAUDE.md(pin line, the0012row), README badge,LlamaCppVersion, CHANGELOG.Test plan
spotbugs:checkat 0 bugs (thelombok.configchange needs a clean build); the agent compiles against JLine 4.4.8. At b11574: a freshFetchContentcheckout through the real applier (all twelve patches, stamp written), the static test build,ctest607/607,NativeLibraryLoadSmokeTest(the pin against the linkedb11574-<commit>),LlamaLoggerTest,RpcServerTest; then the modular build (-DJLLAMA_BACKEND_DL=ON) with the symbol check above andRpcServerTest,LlamaLoggerTest,BackendLoadTest,NativeLibraryLoadSmokeTestover it, 27/27;spotless:check,check-patches.py(12 patches, 99 hunks, 0 problems),check-natives.py(23 jars, 0 disagreements),check-shared-files.py(0 changed here alone).shared-filesjob warns aboutlombok.configuntil the sibling pull requests merge (a sync lands in four steps; the job fails only on a copy changed here alone, which it is not).Related issues / PRs
Same sweep in the sibling repositories: bernardladenthin/BitcoinAddressFinder#387, bernardladenthin/srcmorph#225, bernardladenthin/streambuffer#179 and bernardladenthin/workspace#55 (the canonical
lombok.config, the tool-version row and this bump in the cross-repo status).Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)🤖 Generated with Claude Code
https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Generated by Claude Code