Skip to content

build: spotbugs-maven-plugin 4.10.5.0, checker-qual 4.3.1, JSpecify nullness on Lombok-generated code - #225

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/hopeful-pascal-9jlbqb
Oct 12, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
claude/hopeful-pascal-9jlbqb

Conversation

@bernardladenthin

@bernardladenthin bernardladenthin commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • spotbugs-maven-plugin 4.10.4.1 -> 4.10.5.0 in all three modules (SpotBugs 4.10.5, the first release that reads JSpecify), in step with the sibling repositories.
  • checker-qual 4.3.1 managed in the parent: it had stayed at 4.3.0 next to the 4.3.1 Checker Framework processor (the two must share a version, see the "Java 8 bytecode floor" note in CLAUDE.md).
  • Lombok-generated code carries JSpecify nullness (lombok.addNullAnnotations = jspecify in the shared lombok.config, .github/shared-files.sha256 rewritten): under @NullMarked the parameter of a Lombok-generated equals(Object) read as non-null while Object.equals accepts null, which SpotBugs 4.10.5 reports as NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION; Lombok now writes @Nullable there. The canonical copy is in the workspace policy. CHANGELOG entry.

Test plan

  • Affected unit / integration tests pass locally: mvn -DskipTests -Dllama.version=5.2.0-SNAPSHOT clean compile com.github.spotbugs:spotbugs-maven-plugin:4.10.5.0:check is green reactor-wide with 0 bugs (the property only because net.ladenthin:llama:5.2.0, the pom's unchanged pin, is not on Central yet and the local repository holds the snapshot).
  • CI is green on this branch. The shared-files job warns about lombok.config until the sibling pull requests merge (a sync lands in four steps; the job fails only on a copy changed here alone, which it is not).
  • Docs / CHANGELOG updated where applicable

Related issues / PRs

Same sweep in the sibling repositories: bernardladenthin/java-llama.cpp#533 (spotbugs-maven-plugin 4.10.5.0, the same lombok.config, JLine 4.4.8, llama.cpp b11558 -> b11574), bernardladenthin/BitcoinAddressFinder#387 (spotbugs-maven-plugin 4.10.5.0, the same lombok.config, a static ReaderProgress), bernardladenthin/streambuffer#179 (spotbugs-maven-plugin 4.10.5.0) and bernardladenthin/workspace#55 (the canonical lombok.config in policies/lombok-config.md, the tool-version row).

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes (if there are, I have notified the maintainer privately per SECURITY.md)

🤖 Generated with Claude Code

https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2

…ullness on Lombok-generated code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2

This branch had an error being deployed

1 failed and 1 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants