Repository navigation
build: spotbugs-maven-plugin 4.10.5.0, checker-qual 4.3.1, JSpecify nullness on Lombok-generated code - #225
Merged
Conversation
…ullness on Lombok-generated code Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
bernardladenthin
had a problem deploying
to
maven-central
October 12, 2026 20:50 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 12, 2026 20:50 — with
GitHub Actions
Failure
This was referenced Oct 12, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checker-qual4.3.1 managed in the parent: it had stayed at 4.3.0 next to the 4.3.1 Checker Framework processor (the two must share a version, see the "Java 8 bytecode floor" note inCLAUDE.md).lombok.addNullAnnotations = jspecifyin the sharedlombok.config,.github/shared-files.sha256rewritten): under@NullMarkedthe parameter of a Lombok-generatedequals(Object)read as non-null whileObject.equalsaccepts null, which SpotBugs 4.10.5 reports asNP_METHOD_PARAMETER_TIGHTENS_ANNOTATION; Lombok now writes@Nullablethere. The canonical copy is in the workspace policy. CHANGELOG entry.Test plan
mvn -DskipTests -Dllama.version=5.2.0-SNAPSHOT clean compile com.github.spotbugs:spotbugs-maven-plugin:4.10.5.0:checkis green reactor-wide with 0 bugs (the property only becausenet.ladenthin:llama:5.2.0, the pom's unchanged pin, is not on Central yet and the local repository holds the snapshot).shared-filesjob warns aboutlombok.configuntil the sibling pull requests merge (a sync lands in four steps; the job fails only on a copy changed here alone, which it is not).Related issues / PRs
Same sweep in the sibling repositories: bernardladenthin/java-llama.cpp#533 (spotbugs-maven-plugin 4.10.5.0, the same
lombok.config, JLine 4.4.8, llama.cpp b11558 -> b11574), bernardladenthin/BitcoinAddressFinder#387 (spotbugs-maven-plugin 4.10.5.0, the samelombok.config, a staticReaderProgress), bernardladenthin/streambuffer#179 (spotbugs-maven-plugin 4.10.5.0) and bernardladenthin/workspace#55 (the canonicallombok.configinpolicies/lombok-config.md, the tool-version row).Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)🤖 Generated with Claude Code
https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2