Repository navigation
Fix the Elyra image's default command - #3455
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
==========================================
- Coverage 84.89% 84.89% -0.01%
==========================================
Files 161 161
Lines 19379 19379
Branches 502 502
==========================================
- Hits 16452 16451 -1
- Misses 2887 2888 +1
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lresende
force-pushed
the
fix-image-default-cmd
branch
from
November 14, 2026 22:44
77f6258 to
a36ab0e
Compare
lresende
force-pushed
the
fix-image-default-cmd
branch
2 times, most recently
from
November 15, 2026 15:34
a36f6c3 to
8d79d00
Compare
start-elyra.sh ran start-notebook.sh, which the docker-stacks images provide. Zero to JupyterHub's singleuser sample image was built on jupyter/base-notebook through 1.x, but the 3.3.7 base adopted in 4.1.0 is built on python:3.11-slim and doesn't include it, so a plain `docker run elyra/elyra` exited right away. Zero to JupyterHub wasn't affected because it overrides the command. Start the server directly, as start-notebook.sh did: run jupyterhub-singleuser when a JupyterHub spawner sets JUPYTERHUB_API_TOKEN, and jupyter lab otherwise. Pass arguments with "$@" so they keep their quoting, and drop JUPYTER_ENABLE_LAB, which only start-notebook.sh read. validate-image.sh now checks that the default command starts a Jupyter server. Signed-off-by: Luciano Resende <lresende@apple.com>
lresende
force-pushed
the
fix-image-default-cmd
branch
from
November 15, 2026 15:50
8d79d00 to
46267ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
docker run elyra/elyraexits right away:start-elyra.shranstart-notebook.sh, which comes with the docker-stacks images. Zero to JupyterHub'sk8s-singleuser-sampleimage was built onjupyter/base-notebookthrough 1.x, but the 3.3.7 base adopted in 4.1.0 (#3372) is built onpython:3.11-slim-bullseyeand doesn't include it. Zero to JupyterHub deployments weren't affected because the chart overrides the command withjupyterhub-singleuser.Start script (
etc/docker/elyra/start-elyra.sh):start-notebook.shdid. When JupyterHub spawns the server with the image's default command, which setsJUPYTERHUB_API_TOKEN, it runsjupyterhub-singleuser, which gets its address from the Hub. Otherwise it runsjupyter lab --no-browser --ip=$NB_IP --port=$NB_PORT."$@"instead of$*, so they keep their quoting.JUPYTER_ENABLE_LAB, which onlystart-notebook.shread.Validation:
validate-image.sh(added in #3454) now runs the start script and checks that a Jupyter server answers on/api, in both modes ofmake validate-elyra-image.How was this pull request tested?
start-notebook.sh: No such file or directoryerror above.docker run: with the image's own command, the server answers on/apiand logselyra | extension was successfully loaded.start-elyra.sh --ServerApp.base_url=/user/test/serves/user/test/api.JUPYTERHUB_API_TOKENset,jupyterhub-singleuserstarts and stops atMissing required environment $JUPYTERHUB_SERVICE_URL, which a real Hub provides. Not tested against a running Hub.bash -npasses for both scripts.jupyterhub/k8s-singleuser-sample:3.3.7(the 4.2.0 image with~/.localand~/.cacheremoved), because Docker Hub wasn't reachable from the build environment. To check on the real base:make release elyra-image validate-elyra-image.Developer's Certificate of Origin 1.1