Repository navigation
Persist negative package and build records with bbolt - #1411
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist negative install and build results in bbolt so repeated requests skip oversized archives and known missing paths. GitHub size records are scoped to the exact branch, tag, or hash; npm size records use the exact version. Missing paths are cached per exact package version and build variant, while package-not-found records expire after 10 minutes.
Store records in
<workDir>/negative-cache.db, clear matching records on package purge, and reject cached build misses before they enter the build queue. Apply both download and expanded archive limits to npm packages. Move disk housekeeping to server startup so creating a router does not leave background work running.Validation:
go test ./server/...