Skip to content

[flutter_webrtc] Fix constraint parsing crash and buffer deleter - #1177

Open
seungsoo47 wants to merge 1 commit into
flutter-tizen:mainfrom
seungsoo47:bot/upstream-plugins-webrtc-cpp-fixes
Open

seungsoo47 wants to merge 1 commit into
flutter-tizen:mainfrom
seungsoo47:bot/upstream-plugins-webrtc-cpp-fixes

Conversation

@seungsoo47

Copy link
Copy Markdown
Contributor

Port two fixes from the upstream common C++ implementation:

Port two fixes from the upstream common C++ implementation:

- Skip media constraints with unsupported value types instead of reading
  them as int, which threw std::bad_variant_access (e.g. for null).
  flutter-webrtc/flutter-webrtc#2132
- Hold the RGB frame buffer allocated with new[] in shared_ptr<uint8_t[]>
  so it is released with delete[].
  flutter-webrtc/flutter-webrtc#2039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant