[flutter_webrtc] Fix constraint parsing crash and buffer deleter - #1177
Open
seungsoo47 wants to merge 1 commit into
Open
seungsoo47 wants to merge 1 commit into
seungsoo47 wants to merge 1 commit into
Conversation
Port two fixes from the upstream common C++ implementation: - Skip media constraints with unsupported value types instead of reading them as int, which threw std::bad_variant_access (e.g. for null). flutter-webrtc/flutter-webrtc#2132 - Hold the RGB frame buffer allocated with new[] in shared_ptr<uint8_t[]> so it is released with delete[]. flutter-webrtc/flutter-webrtc#2039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port two fixes from the upstream common C++ implementation: