[flutter_webrtc] Fix constraint parsing crash and buffer deleter

packages/flutter_webrtc/CHANGELOG.md

@@ -1,6 +1,8 @@
-## NEXT
+## 0.2.5
 
 * Follow the analysis options of the frontend plugin.
+* Fix a crash when parsing media constraints with unsupported value types.
+* Fix a mismatched `delete` of the video frame buffer.
 
 ## 0.2.4
 

packages/flutter_webrtc/README.md

@@ -41,7 +41,7 @@ For other Tizen devices :
  ```yaml
 dependencies:
   flutter_webrtc: ^1.4.1
-  flutter_webrtc_tizen: ^0.2.4
+  flutter_webrtc_tizen: ^0.2.5
 ```
 
 ## Functionality

packages/flutter_webrtc/example/flutter_webrtc_example/integration_test/flutter_webrtc_test.dart

@@ -49,6 +49,15 @@ void main() {
       timeout: const Timeout(Duration(seconds: 10)),
     );
 
+    test('createOffer ignores constraints with unsupported values', () async {
+      final pc = await createPeerConnection(_kConfig);
+      final offer = await pc.createOffer(<String, dynamic>{
+        'mandatory': <String, dynamic>{'unsupported': null},
+      });
+      expect(offer.type, equals('offer'));
+      await pc.close();
+    }, timeout: const Timeout(Duration(seconds: 10)));
+
     test('setLocalDescription succeeds', () async {
       final pc = await createPeerConnection(_kConfig);
       final offer = await pc.createOffer();

packages/flutter_webrtc/pubspec.yaml

@@ -2,7 +2,7 @@ name: flutter_webrtc_tizen
 homepage: https://github.com/flutter-tizen/plugins
 description: Flutter WebRTC plugin for Tizen, based on GoogleWebRTC.
 repository: https://github.com/flutter-tizen/plugins/tree/main/packages/flutter_webrtc
-version: 0.2.4
+version: 0.2.5
 
 environment:
   sdk: ">=3.3.0 <4.0.0"

packages/flutter_webrtc/tizen/inc/flutter_video_renderer.h

@@ -53,7 +53,7 @@ class FlutterVideoRenderer
   scoped_refptr<RTCVideoFrame> frame_;
   std::unique_ptr<flutter::TextureVariant> texture_;
   std::shared_ptr<FlutterDesktopPixelBuffer> pixel_buffer_;
-  mutable std::shared_ptr<uint8_t> rgb_buffer_;
+  mutable std::shared_ptr<uint8_t[]> rgb_buffer_;
   mutable std::mutex mutex_;
   RTCVideoFrame::VideoRotation rotation_ = RTCVideoFrame::kVideoRotation_0;
 };

packages/flutter_webrtc/tizen/src/flutter_webrtc_base.cc

@@ -140,7 +140,7 @@ void FlutterWebRTCBase::ParseConstraints(
       value = GetValue<bool>(v) ? RTCMediaConstraints::kValueTrue
                                 : RTCMediaConstraints::kValueFalse;
     } else {
-      value = std::to_string(GetValue<int>(v));
+      continue;
     }
     if (type == kMandatory) {
       mediaConstraints->AddMandatoryConstraint(key.c_str(), value.c_str());